Fixed coverity reported concurrency issues

sedukull · sedukull · commit 6bccf5ff41ee · 2014-08-06T17:28:49.000+05:30
diff --git a/agent/src/com/cloud/agent/dao/impl/PropertiesStorage.java b/agent/src/com/cloud/agent/dao/impl/PropertiesStorage.java
@@ -66,7 +66,7 @@ public synchronized void persist(String key, String value) {
     }
 
     @Override
-    public boolean configure(String name, Map<String, Object> params) {
+    public synchronized boolean configure(String name, Map<String, Object> params) {
         _name = name;
         String path = (String)params.get("path");
         if (path == null) {
@@ -86,7 +86,6 @@ public boolean configure(String name, Map<String, Object> params) {
                 return false;
             }
         }
-
         try {
             PropertiesUtil.loadFromFile(_properties, file);
             _file = file;
@@ -97,7 +96,6 @@ public boolean configure(String name, Map<String, Object> params) {
             s_logger.error("IOException: ", e);
             return false;
         }
-
         return true;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ public synchronized void persist(String key, String value) {`
`66`	`66`	`}`
`67`	`67`
`68`	`68`	`@Override`
`69`		`- public boolean configure(String name, Map<String, Object> params) {`
	`69`	`+ public synchronized boolean configure(String name, Map<String, Object> params) {`
`70`	`70`	`_name = name;`
`71`	`71`	`String path = (String)params.get("path");`
`72`	`72`	`if (path == null) {`
`@@ -86,7 +86,6 @@ public boolean configure(String name, Map<String, Object> params) {`
`86`	`86`	`return false;`
`87`	`87`	`}`
`88`	`88`	`}`
`89`		`-`
`90`	`89`	`try {`
`91`	`90`	`PropertiesUtil.loadFromFile(_properties, file);`
`92`	`91`	`_file = file;`
`@@ -97,7 +96,6 @@ public boolean configure(String name, Map<String, Object> params) {`
`97`	`96`	`s_logger.error("IOException: ", e);`
`98`	`97`	`return false;`
`99`	`98`	`}`
`100`		`-`
`101`	`99`	`return true;`
`102`	`100`	`}`
`103`	`101`