Cleaned up more of the api

dcrescim · dcrescim · commit ecc4160793a8 · 2021-11-05T12:19:41.000-07:00
diff --git a/src/dummy/dummy.classifier.ts b/src/dummy/dummy.classifier.ts
@@ -26,10 +26,9 @@ import { PredictorMixin } from '../mixins'
 /**
  * Supported strategies for this classifier.
  */
-type Strategy = 'mostFrequent' | 'uniform' | 'constant'
 
 export interface DummyClassifierParams {
-  strategy?: Strategy
+  strategy?: 'mostFrequent' | 'uniform' | 'constant'
   fill?: number
 }
 
diff --git a/src/dummy/dummy.regressor.ts b/src/dummy/dummy.regressor.ts
@@ -26,8 +26,6 @@ import { PredictorMixin } from '../mixins'
  * Supported strategies for DummyRegressor
  */
 
-type Strategy = 'mean' | 'median' | 'constant'
-
 export interface DummyRegressorParams {
   /**
    * The strategy that this DummyRegressor will use to make a prediction.
@@ -36,7 +34,7 @@ export interface DummyRegressorParams {
    * If 'mean' is chosen then the DummyRegressor will just "guess" the 'mean'
    * of the target variable as it's prediction.
    */
-  strategy: Strategy
+  strategy?: 'mean' | 'median' | 'constant'
 
   /**
    * In the case where you chose 'constant' as your strategy, the fill number
@@ -49,9 +47,7 @@ export default class DummyRegressor extends PredictorMixin {
   $fill: number
   $strategy: string
 
-  constructor(
-    { strategy, fill }: DummyRegressorParams = { strategy: 'mean' }
-  ) {
+  constructor({ strategy = 'mean', fill }: DummyRegressorParams = {}) {
     super()
     this.$fill = fill || 0
     this.$strategy = strategy
diff --git a/tsconfig.json b/tsconfig.json
@@ -9,8 +9,8 @@
     "outDir": "./dist" /* Redirect output structure to the directory. */,
     "strict": true /* Enable all strict type-checking options. */,
     "noImplicitAny": true /* Raise error on expressions and declarations with an implied 'any' type. */,
-    // "noUnusedLocals": true,                /* Report errors on unused locals. */
-    // "noUnusedParameters": true,            /* Report errors on unused parameters. */
+    // "noUnusedLocals": true /* Report errors on unused locals. */,
+    // "noUnusedParameters": true /* Report errors on unused parameters. */,
     "noFallthroughCasesInSwitch": true /* Report errors for fallthrough cases in switch statement. */,
     "esModuleInterop": true /* Enables emit interoperability between CommonJS and ES Modules via creation of namespace objects for all imports. Implies 'allowSyntheticDefaultImports'. */,
     "resolveJsonModule": true /* Include modules imported with '.json' extension */,
