Set header to true as default in readCSV

risenW · risenW · commit df89bf9ae412 · 2022-01-02T22:33:27.000+01:00
diff --git a/.gitignore b/.gitignore
@@ -4,3 +4,6 @@ test/fixtures/titanicO*
 danfojs-node/test/samples/test*
 danfojs-node/test/samples/titanicO*
 danfojs-node/test/samples/sampleO*
+src/danfojs-node/test/samples/sampleOut.xlsx
+src/danfojs-node/test/samples/test.xlsx
+src/danfojs-node/test/samples/testSeries.xlsx
diff --git a/src/danfojs-browser/src/io/io.csv.ts b/src/danfojs-browser/src/io/io.csv.ts
@@ -49,6 +49,7 @@ import { CsvInputOptions, CsvOutputOptionsBrowser } from "../types"
 const $readCSV = async (file: any, options?: CsvInputOptions): Promise<DataFrame> => {
   return new Promise(resolve => {
     Papa.parse(file, {
+      header: true,
       ...options,
       download: true,
       complete: results => {
@@ -79,6 +80,7 @@ const $streamCSV = async (file: string, callback: (df: DataFrame) => void, optio
     let count = -1
     Papa.parse(file, {
       ...options,
+      header: true,
       download: true,
       step: results => {
         const df = new DataFrame([results.data], { index: [count++] });
diff --git a/src/danfojs-node/src/io/io.csv.ts b/src/danfojs-node/src/io/io.csv.ts
@@ -51,8 +51,13 @@ import { CsvInputOptions, CsvOutputOptionsNode } from "../types"
 const $readCSV = async (filePath: string, options?: CsvInputOptions): Promise<DataFrame> => {
   if (filePath.startsWith("http") || filePath.startsWith("https")) {
     return new Promise(resolve => {
+      const optionsWithDefaults = {
+        header: true,
+        ...options,
+      }
+
       const dataStream = request.get(filePath);
-      const parseStream: any = Papa.parse(Papa.NODE_STREAM_INPUT, options);
+      const parseStream: any = Papa.parse(Papa.NODE_STREAM_INPUT, optionsWithDefaults);
       dataStream.pipe(parseStream);
 
       const data: any = [];
@@ -69,6 +74,7 @@ const $readCSV = async (filePath: string, options?: CsvInputOptions): Promise<Da
     return new Promise(resolve => {
       const fileStream = fs.createReadStream(filePath)
       Papa.parse(fileStream, {
+        header: true,
         ...options,
         complete: results => {
           const df = new DataFrame(results.data);
@@ -97,10 +103,14 @@ const $readCSV = async (filePath: string, options?: CsvInputOptions): Promise<Da
 const $streamCSV = async (filePath: string, callback: (df: DataFrame) => void, options?: CsvInputOptions): Promise<null> => {
 
   if (filePath.startsWith("http") || filePath.startsWith("https")) {
+    const optionsWithDefaults = {
+      header: true,
+      ...options,
+    }
     return new Promise(resolve => {
       let count = -1
       const dataStream = request.get(filePath);
-      const parseStream: any = Papa.parse(Papa.NODE_STREAM_INPUT, options);
+      const parseStream: any = Papa.parse(Papa.NODE_STREAM_INPUT, optionsWithDefaults);
       dataStream.pipe(parseStream);
 
       parseStream.on("data", (chunk: any) => {
@@ -119,6 +129,7 @@ const $streamCSV = async (filePath: string, callback: (df: DataFrame) => void, o
     return new Promise(resolve => {
       let count = -1
       Papa.parse(fileStream, {
+        header: true,
         ...options,
         step: results => {
           const df = new DataFrame([results.data], { index: [count++] });
