Commit 99e8772

committed

Handle Unversioned Current and Ramping Version (temporalio#7244)

## What changed? - The initial current version of a worker deployment is now `"__unversioned__"` instead of `""` - When the ramping version of a worker deployment becomes unversioned, the deployment tells all the task queues in the current version that they now have an unversioned ramp. - If the unversioned ramp is promoted to current version, or if the unversioned ramping version is unset, the deployment tells all the task queues of the previous current version that they no longer have an unversioned ramp. ## Why?  ## How did you test it? - Made sure all existing WorkerDeploymentSuite and DeploymentVersionSuite tests pass - Wrote new tests in WorkerDeploymentSuite for the specific edge cases that this code handles: - `TestSetCurrentVersion_Unversioned_NoRamp`: Test that when current version changes from versioned -> unversioned, the task queues become unversioned - `TestSetCurrentVersion_Unversioned_PromoteUnversionedRamp`: Test that when the current version changes from versioned -> unversioned and unversioned was previously ramping, the task queues become unversioned with no more unversioned ramp - `TestSetRampingVersion_Unversioned_UnversionedCurrent`: Test that this fails with "Ramping version __unversioned__ is already current" error - `TestSetRampingVersion_Unversioned_VersionedCurrent`: Test that the ramping version of the current version's task queues becomes unversioned ## Potential risks  ## Documentation  ## Is hotfix candidate?  --------- Co-authored-by: Shivam <57200924+shivs11@users.noreply.github.com> Co-authored-by: Shahab Tajik <shahab@temporal.io> Co-authored-by: Shivam Saraf <shivam.saraf@temporal.io> Co-authored-by: ShahabT <shahab.tajik@temporal.io>

1 parent 7915d2b commit 99e8772Copy full SHA for 99e8772

15 files changed

api
- deployment/v1
  - message.go-helpers.pb.go
  - message.pb.go
- persistence/v1
  - task_queues.pb.go
common/worker_versioning
- worker_versioning.go
- worker_versioning_test.go
proto/internal/temporal/server/api
- deployment/v1
  - message.proto
- persistence/v1
  - task_queues.proto
service
- matching
  - matching_engine.go
  - task_queue_partition_manager.go
- worker/workerdeployment
tests
- deployment_version_test.go
- worker_deployment_test.go

`‎api/deployment/v1/message.go-helpers.pb.go‎`

Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Comments

(0)