Updated clone examples to use the new cert check API

John Haley · John Haley · commit b8c1203f0a73 · 2015-02-13T12:14:51.000-07:00
diff --git a/examples/clone.js b/examples/clone.js
@@ -9,7 +9,15 @@ fse.remove(path).then(function() {
   nodegit.Clone.clone(
     "https://github.com/nodegit/nodegit.git",
     path,
-    { ignoreCertErrors: 1})
+    {
+      remoteCallbacks: {
+        certificateCheck: function() {
+          // github will fail cert check on some OSX machines
+          // this overrides that check
+          return 1;
+        }
+      }
+    })
   .then(function(repo) {
     return repo.getCommit("59b20b8d5c6ff8d09518454d4dd8b7b30f095ab5");
   })
diff --git a/examples/cloneFromGithubWith2Factor.js b/examples/cloneFromGithubWith2Factor.js
@@ -25,10 +25,12 @@ var opts = { ignoreCertErrors: 1};
 var repoUrl = "https://github.com/" + repoOwner + "/" + repoName + ".git";
 
 var opts = {
-  ignoreCertErrors: 1,
   remoteCallbacks: {
     credentials: function() {
       return nodegit.Cred.userpassPlaintextNew (token, "x-oauth-basic");
+    },
+    certificateCheck: function() {
+      return 1;
     }
   }
 };

Original file line number	Diff line number	Diff line change
`@@ -25,10 +25,12 @@ var opts = { ignoreCertErrors: 1};`
`25`	`25`	`var repoUrl = "https://github.com/" + repoOwner + "/" + repoName + ".git";`
`26`	`26`
`27`	`27`	`var opts = {`
`28`		`- ignoreCertErrors: 1,`
`29`	`28`	`remoteCallbacks: {`
`30`	`29`	`credentials: function() {`
`31`	`30`	`return nodegit.Cred.userpassPlaintextNew (token, "x-oauth-basic");`
	`31`	`+ },`
	`32`	`+ certificateCheck: function() {`
	`33`	`+ return 1;`
`32`	`34`	`}`
`33`	`35`	`}`
`34`	`36`	`};`