Force functions with callbacks to be async

John Haley · John Haley · commit 0a7ac52d1058 · 2015-02-24T12:36:43.000-07:00
If a function has a callback then it must be async. If it isn't
then we'll hit a deadlocked state when waiting for the JS
callback.
diff --git a/generate/scripts/helpers.js b/generate/scripts/helpers.js
@@ -302,6 +302,11 @@ var Helpers = {
     var argOverrides = fnOverrides.args || {};
     fnDef.args.forEach(function(arg) {
       Helpers.decorateArg(arg, fnDef.args, typeDef, fnDef, argOverrides[arg.name] || {}, enums);
+
+      // if a function has any callbacks then it MUST be async
+      if (arg.isCallbackFunction) {
+        fnDef.isAsync = true;
+      }
     });
 
     if (fnDef.return) {
