Deprecate toJavaArray: unsafe

jbgi · jbgi · commit 5e6da6f8673e · 2016-05-24T07:39:11.000+02:00
diff --git a/core/src/main/java/fj/data/Array.java b/core/src/main/java/fj/data/Array.java
@@ -128,7 +128,14 @@ public Object[] array() {
     return copyOf(a, a.length);
   }
 
-  @SuppressWarnings("unchecked")
+  /**
+   * To be removed in future release:
+   * affectation of the result of this method to a non generic array
+   * will result in runtime error (ClassCastException).
+   *
+   * @deprecated use {@link #array(Class)}
+   */
+  @Deprecated
   public A[] toJavaArray() {
     return (A[]) array();
   }
diff --git a/core/src/main/java/fj/data/List.java b/core/src/main/java/fj/data/List.java
@@ -211,7 +211,14 @@ public final Object[] toArrayObject() {
     return a;
   }
 
-  @SuppressWarnings("unchecked")
+  /**
+   * To be removed in future release:
+   * affectation of the result of this method to a non generic array
+   * will result in runtime error (ClassCastException).
+   *
+   * @deprecated use {@link #array(Class)}
+   */
+  @Deprecated
   public final A[] toJavaArray() {
     return (A[]) toArrayObject();
   }
diff --git a/core/src/main/java/fj/data/Stream.java b/core/src/main/java/fj/data/Stream.java
@@ -916,7 +916,14 @@ public final Option<A> toOption() {
     return isEmpty() ? Option.<A>none() : some(head());
   }
 
-  @SuppressWarnings({"unchecked", "UnnecessaryFullyQualifiedName"})
+  /**
+   * To be removed in future release:
+   * affectation of the result of this method to a non generic array
+   * will result in runtime error (ClassCastException).
+   *
+   * @deprecated use {@link #array(Class)}
+   */
+  @Deprecated
   public final A[] toJavaArray() {
     final A[] array = (A[]) new Object[length()];
     int i = 0;
diff --git a/core/src/test/java/fj/data/ArrayTest.java b/core/src/test/java/fj/data/ArrayTest.java
@@ -3,6 +3,7 @@
 import org.junit.Test;
 
 import static org.hamcrest.CoreMatchers.equalTo;
+import static org.hamcrest.CoreMatchers.instanceOf;
 import static org.junit.Assert.assertThat;
 
 /**
@@ -11,10 +12,10 @@
 public class ArrayTest {
 
     @Test
-    public void toJavaArray() {
-        final int max = 3;
-        List<Integer> list = List.range(1, max + 1);
-        assertThat(list.toArray().toJavaArray(), equalTo(list.toJavaArray()));
+    public void array_is_safe() {
+        List<Integer> list = List.range(1, 2);
+
+        assertThat(list.toArray().array(Integer[].class), instanceOf(Integer[].class));
     }
 
 }
