Merge pull request open-source-parsers#118 from datadiode/47_fix_value_swap

cdunn2001 · cdunn2001 · commit 55db3c3cb260 · 2015-01-18T11:31:47.000-06:00
swap comments too * Changed `operator=` to exclude start/limit, which should never have been added. * Changed `swap` to include comments. Hmm. That affects efficiency (but *not* for `operator=`) and probably nothing else in practice. - issue open-source-parsers#47
diff --git a/include/json/value.h b/include/json/value.h
@@ -240,8 +240,6 @@ Json::Value obj_value(Json::objectValue); // {}
 
   Value& operator=(Value other);
   /// Swap values.
-  /// \note Currently, comments are intentionally not swapped, for
-  /// both logic and efficiency.
   void swap(Value& other);
 
   ValueType type() const;
@@ -444,6 +442,9 @@ Json::Value obj_value(Json::objectValue); // {}
 
   Value& resolveReference(const char* key, bool isStatic);
 
+  /// Swap values but leave comments and source offsets in place.
+  void swapPayload(Value& other);
+
 #ifdef JSON_VALUE_USE_INTERNAL_MAP
   inline bool isItemAvailable() const { return itemIsUsed_ == 0; }
 
diff --git a/src/lib_json/json_value.cpp b/src/lib_json/json_value.cpp
@@ -406,18 +406,23 @@ Value::~Value() {
 }
 
 Value& Value::operator=(Value other) {
-  swap(other);
+  swapPayload(other);
   return *this;
 }
 
-void Value::swap(Value& other) {
+void Value::swapPayload(Value& other) {
   ValueType temp = type_;
   type_ = other.type_;
   other.type_ = temp;
   std::swap(value_, other.value_);
   int temp2 = allocated_;
   allocated_ = other.allocated_;
   other.allocated_ = temp2;
+}
+
+void Value::swap(Value& other) {
+  swapPayload(other);
+  std::swap(comments_, other.comments_);
   std::swap(start_, other.start_);
   std::swap(limit_, other.limit_);
 }
