Skip to content

Commit 0af6279

Browse files
author
Tim Molter
committed
[all] remove unecessary unchecked throws ExchangeException, NotAvailableFromExchangeException, NotYetImplementedForExchangeException and reformat code
1 parent 1c0e88c commit 0af6279

212 files changed

Lines changed: 675 additions & 817 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎pom.xml‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
2-
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
2+
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
3+
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
34

45
<modelVersion>4.0.0</modelVersion>
56

‎xchange-anx/pom.xml‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
1+
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
2+
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
23

34
<modelVersion>4.0.0</modelVersion>
45
<parent>

‎xchange-binance/pom.xml‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
2-
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
2+
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
3+
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
34
<parent>
45
<artifactId>xchange-parent</artifactId>
56
<groupId>org.knowm.xchange</groupId>

‎xchange-binance/src/main/java/org/knowm/xchange/binance/service/BinanceAccountService.java‎

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,7 @@
1717
import org.knowm.xchange.dto.account.FundingRecord.Status;
1818
import org.knowm.xchange.dto.account.FundingRecord.Type;
1919
import org.knowm.xchange.dto.account.Wallet;
20-
import org.knowm.xchange.exceptions.ExchangeException;
2120
import org.knowm.xchange.exceptions.NotAvailableFromExchangeException;
22-
import org.knowm.xchange.exceptions.NotYetImplementedForExchangeException;
2321
import org.knowm.xchange.service.account.AccountService;
2422
import org.knowm.xchange.service.trade.params.DefaultWithdrawFundsParams;
2523
import org.knowm.xchange.service.trade.params.HistoryParamsFundingType;
@@ -45,14 +43,14 @@ public AccountInfo getAccountInfo() throws IOException {
4543

4644
@Override
4745
public String withdrawFunds(Currency currency, BigDecimal amount, String address)
48-
throws ExchangeException, NotAvailableFromExchangeException, NotYetImplementedForExchangeException, IOException {
46+
throws IOException {
4947
withdraw0(currency.getCurrencyCode(), address, amount);
5048
return null;
5149
}
5250

5351
@Override
5452
public String withdrawFunds(WithdrawFundsParams params)
55-
throws ExchangeException, NotAvailableFromExchangeException, NotYetImplementedForExchangeException, IOException {
53+
throws IOException {
5654
if (!(params instanceof DefaultWithdrawFundsParams)) {
5755
throw new RuntimeException("DefaultWithdrawFundsParams must be provided.");
5856
}
@@ -69,7 +67,7 @@ private void withdraw0(String asset, String address, BigDecimal amount) throws I
6967

7068
@Override
7169
public String requestDepositAddress(Currency currency, String... args)
72-
throws ExchangeException, NotAvailableFromExchangeException, NotYetImplementedForExchangeException, IOException {
70+
throws IOException {
7371
throw new NotAvailableFromExchangeException();
7472
}
7573

@@ -80,7 +78,7 @@ public TradeHistoryParams createFundingHistoryParams() {
8078

8179
@Override
8280
public List<FundingRecord> getFundingHistory(TradeHistoryParams params)
83-
throws ExchangeException, NotAvailableFromExchangeException, NotYetImplementedForExchangeException, IOException {
81+
throws IOException {
8482
if (params instanceof TradeHistoryParamCurrency) {
8583
throw new RuntimeException("You must provide the currency in order to get the funding history (TradeHistoryParamCurrency).");
8684
}

‎xchange-binance/src/main/resources/binance.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
{
2-
"currency_pairs": { }
2+
"currency_pairs": {}
33
}

‎xchange-bitbay/pom.xml‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
1+
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
2+
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
23

34
<modelVersion>4.0.0</modelVersion>
45

‎xchange-bitbay/src/main/java/org/knowm/xchange/bitbay/service/BitbayAccountService.java‎

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
import org.knowm.xchange.currency.Currency;
1010
import org.knowm.xchange.dto.account.AccountInfo;
1111
import org.knowm.xchange.dto.account.FundingRecord;
12-
import org.knowm.xchange.exceptions.ExchangeException;
1312
import org.knowm.xchange.exceptions.NotAvailableFromExchangeException;
1413
import org.knowm.xchange.exceptions.NotYetImplementedForExchangeException;
1514
import org.knowm.xchange.service.account.AccountService;
@@ -34,18 +33,18 @@ public AccountInfo getAccountInfo() throws IOException {
3433

3534
@Override
3635
public String withdrawFunds(Currency currency, BigDecimal amount,
37-
String address) throws ExchangeException, NotAvailableFromExchangeException, NotYetImplementedForExchangeException, IOException {
36+
String address) throws IOException {
3837
throw new NotYetImplementedForExchangeException();
3938
}
4039

4140
@Override
42-
public String withdrawFunds(WithdrawFundsParams params) throws ExchangeException, NotAvailableFromExchangeException, NotYetImplementedForExchangeException, IOException {
41+
public String withdrawFunds(WithdrawFundsParams params) throws IOException {
4342
throw new NotYetImplementedForExchangeException();
4443
}
4544

4645
@Override
4746
public String requestDepositAddress(Currency currency,
48-
String... args) throws ExchangeException, NotAvailableFromExchangeException, NotYetImplementedForExchangeException, IOException {
47+
String... args) throws IOException {
4948
throw new NotYetImplementedForExchangeException();
5049
}
5150

@@ -55,7 +54,7 @@ public TradeHistoryParams createFundingHistoryParams() {
5554
}
5655

5756
@Override
58-
public List<FundingRecord> getFundingHistory(TradeHistoryParams params) throws ExchangeException, NotAvailableFromExchangeException, NotYetImplementedForExchangeException, IOException {
57+
public List<FundingRecord> getFundingHistory(TradeHistoryParams params) throws IOException {
5958
Currency currency = null;
6059
if (params instanceof TradeHistoryParamCurrency) {
6160
TradeHistoryParamCurrency tradeHistoryParamCurrency = (TradeHistoryParamCurrency) params;

‎xchange-bitbay/src/main/java/org/knowm/xchange/bitbay/service/BitbayTradeService.java‎

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,7 @@
1717
import org.knowm.xchange.dto.trade.OpenOrders;
1818
import org.knowm.xchange.dto.trade.UserTrade;
1919
import org.knowm.xchange.dto.trade.UserTrades;
20-
import org.knowm.xchange.exceptions.ExchangeException;
2120
import org.knowm.xchange.exceptions.NotAvailableFromExchangeException;
22-
import org.knowm.xchange.exceptions.NotYetImplementedForExchangeException;
2321
import org.knowm.xchange.service.trade.TradeService;
2422
import org.knowm.xchange.service.trade.params.CancelOrderByIdParams;
2523
import org.knowm.xchange.service.trade.params.CancelOrderParams;
@@ -38,41 +36,41 @@ public BitbayTradeService(Exchange exchange) {
3836
}
3937

4038
@Override
41-
public OpenOrders getOpenOrders() throws ExchangeException, NotAvailableFromExchangeException, NotYetImplementedForExchangeException, IOException {
39+
public OpenOrders getOpenOrders() throws IOException {
4240
return getOpenOrders(createOpenOrdersParams());
4341
}
4442

4543
@Override
4644
public OpenOrders getOpenOrders(
47-
OpenOrdersParams params) throws ExchangeException, NotAvailableFromExchangeException, NotYetImplementedForExchangeException, IOException {
45+
OpenOrdersParams params) throws IOException {
4846
List<BitbayOrder> response = getBitbayOpenOrders();
4947
return BitbayAdapters.adaptOpenOrders(response);
5048
}
5149

5250
@Override
5351
public String placeMarketOrder(
54-
MarketOrder marketOrder) throws ExchangeException, NotAvailableFromExchangeException, NotYetImplementedForExchangeException, IOException {
52+
MarketOrder marketOrder) throws IOException {
5553

5654
throw new NotAvailableFromExchangeException();
5755
}
5856

5957
@Override
6058
public String placeLimitOrder(
61-
LimitOrder limitOrder) throws ExchangeException, NotAvailableFromExchangeException, NotYetImplementedForExchangeException, IOException {
59+
LimitOrder limitOrder) throws IOException {
6260

6361
BitbayTradeResponse response = placeBitbayOrder(limitOrder);
6462
return String.valueOf(response.getOrderId());
6563
}
6664

6765
@Override
6866
public boolean cancelOrder(
69-
String orderId) throws ExchangeException, NotAvailableFromExchangeException, NotYetImplementedForExchangeException, IOException {
67+
String orderId) throws IOException {
7068
cancelBitbayOrder(Long.parseLong(orderId));
7169
return true;
7270
}
7371

7472
@Override
75-
public boolean cancelOrder(CancelOrderParams orderParams) throws ExchangeException, NotAvailableFromExchangeException, NotYetImplementedForExchangeException, IOException {
73+
public boolean cancelOrder(CancelOrderParams orderParams) throws IOException {
7674
if (orderParams instanceof CancelOrderByIdParams) {
7775
return cancelOrder(((CancelOrderByIdParams) orderParams).getOrderId());
7876
} else {

‎xchange-bitcoinaverage/pom.xml‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
1+
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
2+
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
23

34
<modelVersion>4.0.0</modelVersion>
45

‎xchange-bitcoincharts/pom.xml‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
1+
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
2+
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
23

34
<modelVersion>4.0.0</modelVersion>
45

0 commit comments

Comments
 (0)