Skip to content

Commit 9aad121

Browse files
committed
Fixed JpaListenerInjectionTest
1 parent 57ac701 commit 9aad121

2 files changed

Lines changed: 17 additions & 15 deletions

File tree

jpa/listeners-injection/pom.xml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,11 @@
66
<groupId>org.javaee7</groupId>
77
<artifactId>jpa</artifactId>
88
<version>1.0-SNAPSHOT</version>
9-
<relativePath>../pom.xml</relativePath>
109
</parent>
10+
1111
<artifactId>jpa-listeners-injection</artifactId>
1212
<packaging>war</packaging>
13+
1314
<name>Java EE 7 Sample: jpa - listeners-injection</name>
1415
<description>JPA 2.1 Entity Listeners injection</description>
1516
</project>

jpa/listeners-injection/src/test/java/org/javaee7/jpa/listeners/JpaListenerInjectionTest.java

Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,14 @@
11
package org.javaee7.jpa.listeners;
22

3+
import static java.util.Arrays.asList;
4+
import static org.hamcrest.CoreMatchers.equalTo;
5+
import static org.hamcrest.CoreMatchers.is;
6+
import static org.junit.Assert.assertThat;
7+
8+
import java.util.List;
9+
10+
import javax.inject.Inject;
11+
312
import org.apache.commons.lang3.tuple.ImmutablePair;
413
import org.javaee7.Parameter;
514
import org.javaee7.ParameterRule;
@@ -11,30 +20,22 @@
1120
import org.junit.Test;
1221
import org.junit.runner.RunWith;
1322

14-
import javax.inject.Inject;
15-
16-
import java.util.Arrays;
17-
import java.util.List;
18-
19-
import static org.hamcrest.CoreMatchers.equalTo;
20-
import static org.hamcrest.CoreMatchers.is;
21-
import static org.hamcrest.collection.IsCollectionWithSize.hasSize;
22-
import static org.junit.Assert.assertThat;
23-
2423
@RunWith(Arquillian.class)
2524
public class JpaListenerInjectionTest {
2625

2726
@Deployment
2827
public static WebArchive deployment() {
2928
return ShrinkWrap.create(WebArchive.class)
3029
.addPackage("org.javaee7.jpa.listeners")
30+
.addPackage(ParameterRule.class.getPackage())
31+
.addPackages(true, "org.apache.commons.lang3")
3132
.addAsResource("META-INF/persistence.xml")
3233
.addAsResource("META-INF/create.sql")
3334
.addAsResource("META-INF/drop.sql")
3435
.addAsResource("META-INF/load.sql");
3536
}
3637

37-
public static final List<ImmutablePair<String, Integer>> movies = Arrays.asList(
38+
public static final List<ImmutablePair<String, Integer>> movies = asList(
3839
new ImmutablePair<>("The Matrix", 60),
3940
new ImmutablePair<>("The Lord of The Rings", 70),
4041
new ImmutablePair<>("Inception", 80),
@@ -45,14 +46,14 @@ public static WebArchive deployment() {
4546
public ParameterRule<ImmutablePair<String, Integer>> rule = new ParameterRule<>(movies);
4647

4748
@Parameter
48-
ImmutablePair<String, Integer> expectedMovie;
49+
private ImmutablePair<String, Integer> expectedMovie;
4950

5051
@Inject
51-
MovieBean bean;
52+
private MovieBean bean;
5253

5354
@Test
5455
public void should_provide_movie_rating_via_jpa_listener_injection() {
55-
//given
56+
// Given
5657
Movie movie = bean.getMovieByName(expectedMovie.getLeft());
5758

5859
assertThat(movie.getRating(), is(equalTo(expectedMovie.getRight())));

0 commit comments

Comments
 (0)