fix(cli): display pasted session token (coder#9710)

ericpaulsen · web-flow · commit fae8a470dfbf · 2023-09-20T12:41:59.000-04:00
diff --git a/cli/login.go b/cli/login.go
@@ -278,8 +278,7 @@ func (r *RootCmd) login() *clibase.Cmd {
 				}
 
 				sessionToken, err = cliui.Prompt(inv, cliui.PromptOptions{
-					Text:   "Paste your token here:",
-					Secret: true,
+					Text: "Paste your token here:",
 					Validate: func(token string) error {
 						client.SetSessionToken(token)
 						_, err := client.User(ctx, codersdk.Me)
diff --git a/cli/login_test.go b/cli/login_test.go
@@ -3,6 +3,7 @@ package cli_test
 import (
 	"context"
 	"fmt"
+	"runtime"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
@@ -170,6 +171,10 @@ func TestLogin(t *testing.T) {
 
 		pty.ExpectMatch("Paste your token here:")
 		pty.WriteLine(client.SessionToken())
+		if runtime.GOOS != "windows" {
+			// For some reason, the match does not show up on Windows.
+			pty.ExpectMatch(client.SessionToken())
+		}
 		pty.ExpectMatch("Welcome to Coder")
 		<-doneChan
 	})
@@ -193,6 +198,10 @@ func TestLogin(t *testing.T) {
 
 		pty.ExpectMatch("Paste your token here:")
 		pty.WriteLine("an-invalid-token")
+		if runtime.GOOS != "windows" {
+			// For some reason, the match does not show up on Windows.
+			pty.ExpectMatch("an-invalid-token")
+		}
 		pty.ExpectMatch("That's not a valid token!")
 		cancelFunc()
 		<-doneChan

Original file line number	Diff line number	Diff line change
`@@ -278,8 +278,7 @@ func (r RootCmd) login() clibase.Cmd {`
`278`	`278`	`}`
`279`	`279`
`280`	`280`	`sessionToken, err = cliui.Prompt(inv, cliui.PromptOptions{`
`281`		`- Text: "Paste your token here:",`
`282`		`- Secret: true,`
	`281`	`+ Text: "Paste your token here:",`
`283`	`282`	`Validate: func(token string) error {`
`284`	`283`	`client.SetSessionToken(token)`
`285`	`284`	`_, err := client.User(ctx, codersdk.Me)`