fix: remove duplication from language of query param error (coder#9069)

kylecarbs · web-flow · commit 9a13814b4688 · 2023-08-13T11:47:44.000-05:00
diff --git a/coderd/httpapi/queryparams.go b/coderd/httpapi/queryparams.go
@@ -45,7 +45,7 @@ func (p *QueryParamParser) ErrorExcessParams(values url.Values) {
 		if _, ok := p.Parsed[k]; !ok {
 			p.Errors = append(p.Errors, codersdk.ValidationError{
 				Field:  k,
-				Detail: fmt.Sprintf("Query param %q is not a valid query param", k),
+				Detail: fmt.Sprintf("%q is not a valid query param", k),
 			})
 		}
 	}
diff --git a/coderd/searchquery/search_test.go b/coderd/searchquery/search_test.go
@@ -142,7 +142,7 @@ func TestSearchWorkspace(t *testing.T) {
 		{
 			Name:                  "ExtraKeys",
 			Query:                 `foo:bar`,
-			ExpectedErrorContains: `Query param "foo" is not a valid query param`,
+			ExpectedErrorContains: `"foo" is not a valid query param`,
 		},
 	}
 
@@ -239,7 +239,7 @@ func TestSearchAudit(t *testing.T) {
 		{
 			Name:                  "ExtraKeys",
 			Query:                 `foo:bar`,
-			ExpectedErrorContains: `Query param "foo" is not a valid query param`,
+			ExpectedErrorContains: `"foo" is not a valid query param`,
 		},
 		{
 			Name:                  "Dates",
@@ -370,7 +370,7 @@ func TestSearchUsers(t *testing.T) {
 		{
 			Name:                  "ExtraKeys",
 			Query:                 `foo:bar`,
-			ExpectedErrorContains: `Query param "foo" is not a valid query param`,
+			ExpectedErrorContains: `"foo" is not a valid query param`,
 		},
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ func (p *QueryParamParser) ErrorExcessParams(values url.Values) {`
`45`	`45`	`if _, ok := p.Parsed[k]; !ok {`
`46`	`46`	`p.Errors = append(p.Errors, codersdk.ValidationError{`
`47`	`47`	`Field: k,`
`48`		`- Detail: fmt.Sprintf("Query param %q is not a valid query param", k),`
	`48`	`+ Detail: fmt.Sprintf("%q is not a valid query param", k),`
`49`	`49`	`})`
`50`	`50`	`}`
`51`	`51`	`}`
Original file line number	Diff line number	Diff line change
`@@ -142,7 +142,7 @@ func TestSearchWorkspace(t *testing.T) {`
`142`	`142`	`{`
`143`	`143`	`Name: "ExtraKeys",`
`144`	`144`	Query: `foo:bar`,
`145`		- ExpectedErrorContains: `Query param "foo" is not a valid query param`,
	`145`	+ ExpectedErrorContains: `"foo" is not a valid query param`,
`146`	`146`	`},`
`147`	`147`	`}`
`148`	`148`
`@@ -239,7 +239,7 @@ func TestSearchAudit(t *testing.T) {`
`239`	`239`	`{`
`240`	`240`	`Name: "ExtraKeys",`
`241`	`241`	Query: `foo:bar`,
`242`		- ExpectedErrorContains: `Query param "foo" is not a valid query param`,
	`242`	+ ExpectedErrorContains: `"foo" is not a valid query param`,
`243`	`243`	`},`
`244`	`244`	`{`
`245`	`245`	`Name: "Dates",`
`@@ -370,7 +370,7 @@ func TestSearchUsers(t *testing.T) {`
`370`	`370`	`{`
`371`	`371`	`Name: "ExtraKeys",`
`372`	`372`	Query: `foo:bar`,
`373`		- ExpectedErrorContains: `Query param "foo" is not a valid query param`,
	`373`	+ ExpectedErrorContains: `"foo" is not a valid query param`,
`374`	`374`	`},`
`375`	`375`	`}`
`376`	`376`