Skip to content

Commit d99e733

Browse files
committed
Address the comments in the PR
Improve wording Add code-blocks to improve readability
1 parent 4b9bb66 commit d99e733

File tree

2 files changed

+25
-22
lines changed

2 files changed

+25
-22
lines changed

.github/ISSUE_TEMPLATE.md

Lines changed: 14 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,33 +1,30 @@
1-
Welcome dear friend! We, the rest of the NativeScript community really
1+
Dear friend, we, the rest of the NativeScript community really
22
appreciate your feedback! While we are doing all we can to take care of every
33
issue, sometimes we get overwhelmed. Because of that, we will consider issues
4-
that are not constructive or report problems that cannot be reproduced "dead".
5-
In accordance, we will treat feature requests or bug reports with unanswered
4+
that are not constructive or problems that cannot be reproduced "dead".
5+
Additionally, we will treat feature requests or bug reports with unanswered
66
questions regarding the behavior/reproduction for more than 20 days "dead". All
77
"dead" issues will get closed.
88

9-
## Please, help the others with the details below:
9+
## Please, provide the details below:
1010

11-
### Did you verify this is a real problem with a search in
12-
[StackOverflow](http://stackoverflow.com/questions/tagged/nativescript)
13-
and the other issues here?
11+
### Did you verify this is a real problem by searching [Stack Overflow](http://stackoverflow.com/questions/tagged/nativescript) and the [other open issues in this repo](https://github.com/NativeScript/nativescript/issues)?
1412

1513
### Tell us about the problem
16-
Please, ensure your title is less than 50 characters and starts with a capital
17-
letter. We strive to follow the guidelines in the
18-
[How to Write a Git Commit Message] (http://chris.beams.io/posts/git-commit/)
19-
article for PR titles.
14+
Please, ensure your title is less than 63 characters long and starts with a capital
15+
letter.
2016

21-
### Which platform does it happen on?
17+
### Which platform(s) does your issue occur on?
2218
iOS/Android/Both
2319

24-
### Which versions of the NativeScript elements did you use?
25-
CLI: (run tns --version to fetch it)
20+
### Please provide the following version numbers that your issue occurs with:
21+
CLI: (run `tns --version` to fetch it)
2622
Cross-platform modules: (check the 'version' attribute in the
2723
`node_modules/tns-core-modules/package.json` file in your project)
28-
Runtime: (check the entries in the package.json file of your project)
24+
Runtime(s): (look for the `"tns-android"` and `"tns-ios"` properties in your
25+
project’s `package.json` file)
2926

30-
### Try to recall what were you doing
27+
### Please tell us how to recreate the issue in as much detail as possible.
3128

32-
### Is there code involved? Can you share the minimum of it to get the problem?
29+
### Is there code involved? If so, please share the minimal amount of code needed to recreate the problem.
3330

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,18 @@
11
Dear friend, we, the rest of the NativeScript community thank you for your
2-
contribution! As we want to present a really nice, readable changelog with each
3-
release, we ask you to fill the following information:
2+
contribution! Because we want to present a really nice, readable changelog with each
3+
release, please provide the following information:
44

5-
### Inform what relation and with which issue does it have (in other words, delete the unnecessary):
5+
### Create a meaningful title
6+
Please, ensure your title is less than 50 characters and starts with a capital
7+
letter. We strive to follow the guidelines in the
8+
[How to Write a Git Commit Message] (http://chris.beams.io/posts/git-commit/)
9+
article for PR titles.
10+
11+
### Does your commit message include the wording below to reference a specific issue in this repo?
612
Fixes/Implements #[Issue Number].
713

8-
### Does it have [unit tests](https://github.com/NativeScript/NativeScript/blob/master/running-tests.md)?
14+
### Does your pull request have [unit tests](https://github.com/NativeScript/NativeScript/blob/master/running-tests.md)?
915
If not, why?
10-
If not, can you list any steps to test it manually?
16+
If not, please tell us why tests are not included, and list all steps needed to test your pull request manually.
1117

1218

0 commit comments

Comments
 (0)