Fix breaking change - nativeView property should have setter (NativeScript#4750)

Hristo Hristov · web-flow · commit c98443b33190 · 2017-08-25T11:13:51.000+03:00
Exposed savedInstanceState on LaunchEventArgs so some controls that need Bundle to initialize could get it from there.
diff --git a/tns-core-modules/application/application.d.ts b/tns-core-modules/application/application.d.ts
@@ -80,6 +80,8 @@ export interface LaunchEventData extends ApplicationEventData {
      * If not set a new Frame will be created as a root view in order to maintain backwards compatibility.
      */
     root?: View;
+
+    savedInstanceState?: any /* android.os.Bundle */;
 }
 
 /**
diff --git a/tns-core-modules/ui/core/view-base/view-base.ts b/tns-core-modules/ui/core/view-base/view-base.ts
@@ -217,6 +217,9 @@ export abstract class ViewBase extends Observable implements ViewBaseDefinition
         // this._disableNativeViewRecycling = true;
         return this.nativeViewProtected;
     }
+    set nativeView(value: any) {
+        this.setNativeView(value);
+    }
 
     // TODO: Use Type.prototype.typeName instead.
     get typeName(): string {
diff --git a/tns-core-modules/ui/frame/frame.android.ts b/tns-core-modules/ui/frame/frame.android.ts
@@ -610,7 +610,7 @@ class ActivityCallbacksImplementation implements AndroidActivityCallbacks {
 
         const app = application.android;
         const intent = activity.getIntent();
-        let rootView = this.notifyLaunch(intent);
+        let rootView = this.notifyLaunch(intent, savedInstanceState);
         let frameId = -1;
         const extras = intent.getExtras();
 
@@ -670,8 +670,8 @@ class ActivityCallbacksImplementation implements AndroidActivityCallbacks {
     }
 
     @profile
-    private notifyLaunch(intent: android.content.Intent): View {
-        const launchArgs: application.LaunchEventData = { eventName: application.launchEvent, object: application.android, android: intent };
+    private notifyLaunch(intent: android.content.Intent, savedInstanceState: android.os.Bundle): View {
+        const launchArgs: application.LaunchEventData = { eventName: application.launchEvent, object: application.android, android: intent, savedInstanceState };
         application.notify(launchArgs);
         return launchArgs.root;
     }

Original file line number	Diff line number	Diff line change
`@@ -80,6 +80,8 @@ export interface LaunchEventData extends ApplicationEventData {`
`80`	`80`	`* If not set a new Frame will be created as a root view in order to maintain backwards compatibility.`
`81`	`81`	`*/`
`82`	`82`	`root?: View;`
	`83`	`+`
	`84`	`+ savedInstanceState?: any /* android.os.Bundle */;`
`83`	`85`	`}`
`84`	`86`
`85`	`87`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -217,6 +217,9 @@ export abstract class ViewBase extends Observable implements ViewBaseDefinition`
`217`	`217`	`// this._disableNativeViewRecycling = true;`
`218`	`218`	`return this.nativeViewProtected;`
`219`	`219`	`}`
	`220`	`+ set nativeView(value: any) {`
	`221`	`+ this.setNativeView(value);`
	`222`	`+ }`
`220`	`223`
`221`	`224`	`// TODO: Use Type.prototype.typeName instead.`
`222`	`225`	`get typeName(): string {`