FIX: Now checking that webView.request.URL is not null before accessing properties on it. (NativeScript#4830)

davecoffin · Hristo Hristov · commit 2e09d3714a0e · 2017-10-20T08:36:06.000+03:00
- The symptom is the app would crash when web view tries to load
certain (valid) requests.
diff --git a/tns-core-modules/ui/web-view/web-view.ios.ts b/tns-core-modules/ui/web-view/web-view.ios.ts
@@ -58,8 +58,13 @@ class UIWebViewDelegateImpl extends NSObject implements UIWebViewDelegate {
             traceWrite("UIWebViewDelegateClass.webViewDidFinishLoad(" + webView.request.URL + ")", traceCategories.Debug);
         }
         let owner = this._owner.get();
+        
         if (owner) {
-            owner._onLoadFinished(webView.request.URL.absoluteString);
+            let src = owner.src;
+            if (webView.request && webView.request.URL) {
+                src = webView.request.URL.absoluteString;
+            }
+            owner._onLoadFinished(src);
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -58,8 +58,13 @@ class UIWebViewDelegateImpl extends NSObject implements UIWebViewDelegate {`
`58`	`58`	`traceWrite("UIWebViewDelegateClass.webViewDidFinishLoad(" + webView.request.URL + ")", traceCategories.Debug);`
`59`	`59`	`}`
`60`	`60`	`let owner = this._owner.get();`
	`61`	`+`
`61`	`62`	`if (owner) {`
`62`		`- owner._onLoadFinished(webView.request.URL.absoluteString);`
	`63`	`+ let src = owner.src;`
	`64`	`+ if (webView.request && webView.request.URL) {`
	`65`	`+ src = webView.request.URL.absoluteString;`
	`66`	`+ }`
	`67`	`+ owner._onLoadFinished(src);`
`63`	`68`	`}`
`64`	`69`	`}`
`65`	`70`