npm scripts for typechecking public .d.ts-es and running tslint (NativeScript#2934)

PanayotCankov · enchev · commit 05cd636fc82f · 2016-10-27T15:18:54.000+03:00
* npm scripts for typechecking public .d.ts-es and running tslint

* Update test.ts
diff --git a/apps/app/gallery-app/main-page.ts b/apps/app/gallery-app/main-page.ts
@@ -6,4 +6,3 @@ export function itemTap(args: observable.EventData) {
         moduleName: "gallery-app/" + args.object.get("tag"),
     });
 }
- 
diff --git a/build/tslint.json b/build/tslint.json
@@ -4,7 +4,7 @@
         "curly": true,
         "forin": false,
         "indent": true,
-        "jsdoc-format": true,
+        "jsdoc-format": false,
         "max-line-length": [false, 120],
         "no-arg": true,
         "no-consecutive-blank-lines": true,
diff --git a/package.json b/package.json
@@ -28,7 +28,7 @@
     "nativescript-typedoc-theme": "0.0.7",
     "shelljs": "^0.7.0",
     "time-grunt": "1.3.0",
-    "tslint": "3.4.0",
+    "tslint": "^3.15.1",
     "typedoc": "0.4.5",
     "typescript": "^2.0.3"
   },
@@ -53,6 +53,8 @@
     "test-watch-ios": "npm run pretest && concurrently --kill-others \"npm run tsc-tiw\" \"tns livesync ios --path tests --watch\"",
     "prepublish": "echo \"Development reminder: npm run setup\n\"",
     "typedoc": "typedoc --tsconfig tsconfig.typedoc.json --out bin/dist/apiref --mode file --includeDeclarations --name NativeScript --theme ./node_modules/nativescript-typedoc-theme",
-    "dev-typedoc": "npm run typedoc && cd bin/dist/apiref && http-server"
+    "dev-typedoc": "npm run typedoc && cd bin/dist/apiref && http-server",
+    "test-tsc-es2016": "tsc -p tsconfig.public.es2016.json",
+    "tslint": "tslint --config build/tslint.json 'tns-core-modules/**/*.ts' 'tests/**/*.ts' 'apps/**/*.ts' -e '**/node_modules/**' -e '**/platforms/**'"
   }
 }
diff --git a/tests/app/location-tests.ts b/tests/app/location-tests.ts
@@ -84,8 +84,6 @@ export var testLocation = function (done) {
 
     //TKUnit.waitUntilReady(isReady, 10);
 
-    
-
     //TKUnit.assert(true === locationReceived, locationReceived);
 };
 
diff --git a/tests/app/pages/page17.ts b/tests/app/pages/page17.ts
@@ -36,4 +36,3 @@ export function buttonTap(args: observable.EventData) {
         }
     }
 }
-
diff --git a/tests/app/platform-tests.ts b/tests/app/platform-tests.ts
@@ -38,4 +38,3 @@ export function testIsIOSandIsAndroid() {
         TKUnit.assertTrue(!!android, "isAndroid is true but common 'android' package is not available.");
     }
 }
-
diff --git a/tests/app/ui/button/button-tests-native.d.ts b/tests/app/ui/button/button-tests-native.d.ts
@@ -9,4 +9,3 @@ export declare function getNativeColor(button: buttonModule.Button): colorModule
 export declare function getNativeBackgroundColor(button: buttonModule.Button): colorModule.Color;
 export declare function getNativeTextAlignment(button: buttonModule.Button): string;
 export declare function performNativeClick(button: buttonModule.Button): void;
-
diff --git a/tests/app/ui/list-picker/list-picker-tests-native.ios.ts b/tests/app/ui/list-picker/list-picker-tests-native.ios.ts
@@ -8,5 +8,3 @@ export function selectNativeItem(listPicker: listPickerModule.ListPicker, index:
     listPicker.ios.selectRowInComponentAnimated(index, 0, false);
     (<UIPickerViewDelegate>(<any>listPicker)._delegate).pickerViewDidSelectRowInComponent(listPicker.ios, index, 0);
 }
-
-    
diff --git a/tests/app/ui/list-view/list-view-tests.ts b/tests/app/ui/list-view/list-view-tests.ts
@@ -800,7 +800,6 @@ export class ListViewTest extends testModule.UITest<listViewModule.ListView> {
         TKUnit.assertEqual(templateKey1, "green", "itemTemplateSelector result for second item");
     }
 
-   
     public test_ItemTemplateSelector_IsCorrectlyUsedAsAFunction() {
         let listView = this.testView;
         listView.itemTemplateSelector = selectItemTemplate;
diff --git a/tests/app/ui/repeater/repeater-tests.ts b/tests/app/ui/repeater/repeater-tests.ts
@@ -453,4 +453,3 @@ function getChildAt(repeater: repeaterModule.Repeater, index: number): viewModul
 function getChildAtText(repeater: repeaterModule.Repeater, index: number): string {
     return (<labelModule.Label>getChildAt(repeater, index)).text + "";
 }
-
diff --git a/tests/app/ui/search-bar/search-bar-tests-native.ios.ts b/tests/app/ui/search-bar/search-bar-tests-native.ios.ts
@@ -8,4 +8,3 @@ export function getNativeHintColor(searchBar: SearchBar): Color {
 export function getNativeFontSize(searchBar: SearchBar): number {
     return (<any>searchBar)._textField ? (<any>searchBar)._textField.font.pointSize : undefined;
 }
-
diff --git a/tns-core-modules/bundle-entry-points.ts b/tns-core-modules/bundle-entry-points.ts
@@ -34,4 +34,3 @@ if (global.TNS_WEBPACK) {
     global.registerModule("ui/text-view", () => require("ui/text-view"))
     global.registerModule("ui/time-picker", () => require("ui/time-picker"))
 }
-
diff --git a/tns-core-modules/js-libs/easysax/easysax.d.ts b/tns-core-modules/js-libs/easysax/easysax.d.ts
@@ -8,4 +8,3 @@ declare module "js-libs/easysax" {
         public angularSyntax: boolean;
     }
 }
-
diff --git a/tns-core-modules/text/text.d.ts b/tns-core-modules/text/text.d.ts
@@ -37,4 +37,3 @@ declare module "text" {
         export var UTF_8: any;
     }
 }
-
diff --git a/tns-core-modules/timer/timer.ios.ts b/tns-core-modules/timer/timer.ios.ts
@@ -1,6 +1,4 @@
-﻿/**
- * iOS specific timer functions implementation.
- */
+﻿//iOS specific timer functions implementation.
 var timeoutCallbacks = new Map<number, KeyValuePair<NSTimer, TimerTargetImpl>>();
 var timerId = 0;
 
diff --git a/tns-core-modules/trace/trace.ts b/tns-core-modules/trace/trace.ts
@@ -64,7 +64,6 @@ export function write(message: any, category: string, type?: number) {
         return;
     }
 
-    
     for (i = 0; i < _writers.length; i++) {
         _writers[i].write(message, category, type);
     }
diff --git a/tns-core-modules/ui/builder/builder.ts b/tns-core-modules/ui/builder/builder.ts
@@ -535,7 +535,6 @@ namespace xml2ui {
                             sourceTracker: this.sourceTracker
                         });
                     }
-                    
 
                 } else {
 
diff --git a/tns-core-modules/ui/frame/frame-common.ts b/tns-core-modules/ui/frame/frame-common.ts
@@ -527,4 +527,3 @@ export function goBack(): boolean {
 export function stack(): Array<definition.Frame> {
     return frameStack;
 }
-
diff --git a/tsconfig.public.es2016.json b/tsconfig.public.es2016.json
@@ -0,0 +1,18 @@
+{
+    "compilerOptions": {
+        "noEmitOnError": true,
+        "noEmitHelpers": true,
+        "target": "es5",
+        "module": "commonjs",
+        "declaration": false,
+        "noImplicitAny": false,
+        "noImplicitUseStrict": true,
+        "experimentalDecorators": true,
+        "lib": [
+            "es2016"
+        ]
+    },
+    "files": [
+        "tns-core-modules/tns-core-modules.es2016.d.ts"
+    ]
+}
diff --git a/tsconfig.public.es6.json b/tsconfig.public.es6.json
@@ -0,0 +1,18 @@
+{
+    "compilerOptions": {
+        "noEmitOnError": true,
+        "noEmitHelpers": true,
+        "target": "es5",
+        "module": "commonjs",
+        "declaration": false,
+        "noImplicitAny": false,
+        "noImplicitUseStrict": true,
+        "experimentalDecorators": true,
+        "lib": [
+            "es6"
+        ]
+    },
+    "files": [
+        "tns-core-modules/tns-core-modules.es6.d.ts"
+    ]
+}

Original file line number	Diff line number	Diff line change
`@@ -6,4 +6,3 @@ export function itemTap(args: observable.EventData) {`
`6`	`6`	`moduleName: "gallery-app/" + args.object.get("tag"),`
`7`	`7`	`});`
`8`	`8`	`}`
`9`		`-`
Original file line number	Diff line number	Diff line change
`@@ -36,4 +36,3 @@ export function buttonTap(args: observable.EventData) {`
`36`	`36`	`}`
`37`	`37`	`}`
`38`	`38`	`}`
`39`		`-`
Original file line number	Diff line number	Diff line change
`@@ -38,4 +38,3 @@ export function testIsIOSandIsAndroid() {`
`38`	`38`	`TKUnit.assertTrue(!!android, "isAndroid is true but common 'android' package is not available.");`
`39`	`39`	`}`
`40`	`40`	`}`
`41`		`-`
Original file line number	Diff line number	Diff line change
`@@ -8,5 +8,3 @@ export function selectNativeItem(listPicker: listPickerModule.ListPicker, index:`
`8`	`8`	`listPicker.ios.selectRowInComponentAnimated(index, 0, false);`
`9`	`9`	`(<UIPickerViewDelegate>(<any>listPicker)._delegate).pickerViewDidSelectRowInComponent(listPicker.ios, index, 0);`
`10`	`10`	`}`
`11`		`-`
`12`		`-`
Original file line number	Diff line number	Diff line change
`@@ -800,7 +800,6 @@ export class ListViewTest extends testModule.UITest<listViewModule.ListView> {`
`800`	`800`	`TKUnit.assertEqual(templateKey1, "green", "itemTemplateSelector result for second item");`
`801`	`801`	`}`
`802`	`802`
`803`		`-`
`804`	`803`	`public test_ItemTemplateSelector_IsCorrectlyUsedAsAFunction() {`
`805`	`804`	`let listView = this.testView;`
`806`	`805`	`listView.itemTemplateSelector = selectItemTemplate;`
Original file line number	Diff line number	Diff line change
`@@ -453,4 +453,3 @@ function getChildAt(repeater: repeaterModule.Repeater, index: number): viewModul`
`453`	`453`	`function getChildAtText(repeater: repeaterModule.Repeater, index: number): string {`
`454`	`454`	`return (<labelModule.Label>getChildAt(repeater, index)).text + "";`
`455`	`455`	`}`
`456`		`-`