#1792: Improve performance of marshal.dumps() on large objects by increasing

andrew.kuchling · andrew.kuchling · commit c3942c3efd31 · 2008-05-11T13:33:56.000Z
the size of the buffer more quickly. git-svn-id: http://svn.python.org/projects/python/trunk@63059 6015fed2-1504-0410-9fe1-9d1591cc4771
diff --git a/Lib/test/test_marshal.py b/Lib/test/test_marshal.py
@@ -255,6 +255,14 @@ def test_exact_type_match(self):
             subtyp = type('subtyp', (typ,), {})
             self.assertRaises(ValueError, marshal.dumps, subtyp())
 
+    # Issue #1792 introduced a change in how marshal increases the size of its
+    # internal buffer; this test ensures that the new code is exercised.
+    def test_large_marshal(self):
+        size = int(1e6)
+        testString = 'abc' * size
+        marshal.dumps(testString)
+
+
 def test_main():
     test_support.run_unittest(IntTestCase,
                               FloatTestCase,
diff --git a/Python/marshal.c b/Python/marshal.c
@@ -65,7 +65,10 @@ w_more(int c, WFILE *p)
 	if (p->str == NULL)
 		return; /* An error already occurred */
 	size = PyString_Size(p->str);
-	newsize = size + 1024;
+	newsize = size + size + 1024;
+	if (newsize > 32*1024*1024) {
+		newsize = size + 1024*1024;
+	}
 	if (_PyString_Resize(&p->str, newsize) != 0) {
 		p->ptr = p->end = NULL;
 	}
