Skip to content

Commit b8237bb

Browse files
author
rhettinger
committed
Factor out common boilerplate for test_support
git-svn-id: http://svn.python.org/projects/python/trunk@32501 6015fed2-1504-0410-9fe1-9d1591cc4771
1 parent 9ce53de commit b8237bb

4 files changed

Lines changed: 14 additions & 24 deletions

File tree

Lib/test/test_bisect.py

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -192,24 +192,14 @@ def test_backcompatibility(self):
192192
193193
"""
194194

195-
#==============================================================================
196-
197-
def makeAllTests():
198-
suite = unittest.TestSuite()
199-
for klass in (TestBisect,
200-
TestInsort
201-
):
202-
suite.addTest(unittest.makeSuite(klass))
203-
return suite
204-
205195
#------------------------------------------------------------------------------
206196

207197
__test__ = {'libreftest' : libreftest}
208198

209199
def test_main(verbose=None):
210200
from test import test_bisect
211-
suite = makeAllTests()
212-
test_support.run_suite(suite)
201+
test_support.run_classtests(TestBisect,
202+
TestInsort)
213203
test_support.run_doctest(test_bisect, verbose)
214204

215205
if __name__ == "__main__":

Lib/test/test_bool.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -331,9 +331,7 @@ def test_picklevalues(self):
331331
self.assertEqual(cPickle.dumps(False, True), "I00\n.")
332332

333333
def test_main():
334-
suite = unittest.TestSuite()
335-
suite.addTest(unittest.makeSuite(BoolTest))
336-
test_support.run_suite(suite)
334+
test_support.run_classtests(BoolTest)
337335

338336
if __name__ == "__main__":
339337
test_main()

Lib/test/test_os.py

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
warnings.filterwarnings("ignore", "tempnam", RuntimeWarning, __name__)
1010
warnings.filterwarnings("ignore", "tmpnam", RuntimeWarning, __name__)
1111

12-
from test.test_support import TESTFN, run_suite
12+
from test.test_support import TESTFN, run_classtests
1313

1414
class TemporaryFileTests(unittest.TestCase):
1515
def setUp(self):
@@ -282,14 +282,10 @@ def test_traversal(self):
282282
os.rmdir(TESTFN)
283283

284284
def test_main():
285-
suite = unittest.TestSuite()
286-
for cls in (TemporaryFileTests,
287-
StatAttributeTests,
288-
EnvironTests,
289-
WalkTests,
290-
):
291-
suite.addTest(unittest.makeSuite(cls))
292-
run_suite(suite)
285+
run_classtests(TemporaryFileTests,
286+
StatAttributeTests,
287+
EnvironTests,
288+
WalkTests)
293289

294290
if __name__ == "__main__":
295291
test_main()

Lib/test/test_support.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -233,6 +233,12 @@ def run_unittest(testclass):
233233
"""Run tests from a unittest.TestCase-derived class."""
234234
run_suite(unittest.makeSuite(testclass), testclass)
235235

236+
def run_classtests(*classnames):
237+
suite = unittest.TestSuite()
238+
for cls in classnames:
239+
suite.addTest(unittest.makeSuite(cls))
240+
run_suite(suite)
241+
236242

237243
#=======================================================================
238244
# doctest driver.

0 commit comments

Comments
 (0)