Patch 1413181, by Gabriel Becedillas.

tim.peters · tim.peters · commit a60815bf0737 · 2006-02-27T17:15:31.000Z
PyThreadState_Delete(): if the auto-GIL-state machinery knows about the thread state, forget it (since the thread state is being deleted, continuing to remember it can't help, but can hurt if another thread happens to get created with the same thread id). I'll backport to 2.4 next. git-svn-id: http://svn.python.org/projects/python/trunk@42607 6015fed2-1504-0410-9fe1-9d1591cc4771
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -230,6 +230,12 @@ Core and builtins
   unicode instance if the argument is not an instance of basestring and
   calling __str__ on the argument returns a unicode instance.
 
+- Patch #1413181:  changed ``PyThreadState_Delete()`` to forget about the
+  current thread state when the auto-GIL-state machinery knows about
+  it (since the thread state is being deleted, continuing to remember it
+  can't help, but can hurt if another thread happens to get created with
+  the same thread id).
+
 Extension Modules
 -----------------
 
diff --git a/Python/pystate.c b/Python/pystate.c
@@ -262,6 +262,10 @@ PyThreadState_Delete(PyThreadState *tstate)
 	if (tstate == _PyThreadState_Current)
 		Py_FatalError("PyThreadState_Delete: tstate is still current");
 	tstate_delete_common(tstate);
+#ifdef WITH_THREAD
+	if (autoTLSkey && PyThread_get_key_value(autoTLSkey) == tstate)
+		PyThread_delete_key_value(autoTLSkey);
+#endif /* WITH_THREAD */
 }
 
 

Original file line number	Diff line number	Diff line change
`@@ -262,6 +262,10 @@ PyThreadState_Delete(PyThreadState *tstate)`
`262`	`262`	`if (tstate == _PyThreadState_Current)`
`263`	`263`	`Py_FatalError("PyThreadState_Delete: tstate is still current");`
`264`	`264`	`tstate_delete_common(tstate);`
	`265`	`+#ifdef WITH_THREAD`
	`266`	`+ if (autoTLSkey && PyThread_get_key_value(autoTLSkey) == tstate)`
	`267`	`+ PyThread_delete_key_value(autoTLSkey);`
	`268`	`+#endif /* WITH_THREAD */`
`265`	`269`	`}`
`266`	`270`
`267`	`271`