Bug: warning "Resource leak: 'reader' is never closed" in PathUtil.java

abego · abego · commit 3cc8794a441c · 2017-06-22T18:31:17.000+02:00
diff --git a/sources/net.sf.j2s.ui/src/net/sf/j2s/ui/classpath/PathUtil.java b/sources/net.sf.j2s.ui/src/net/sf/j2s/ui/classpath/PathUtil.java
@@ -11,6 +11,8 @@
 import java.util.List;
 import java.util.Properties;
 
+import net.sf.j2s.core.compiler.FileUtil;
+
 public class PathUtil {
 	public static final String J2S_RESOURCES_LIST = "j2s.resources.list";
 	public static final String J2S_ABANDOMED_RESOURCES_LIST = "j2s.abandoned.resources.list";
@@ -147,8 +149,9 @@ public static String joinArray(String[] list, String seperator) {
 	public static Properties loadJZ(File file) {
 		Properties props = new Properties();
 		if (file.exists()) {
+			FileReader reader = null;
 			try {
-				FileReader reader = new FileReader(file);
+				reader = new FileReader(file);
 				char[] buf = new char[1024];
 				StringBuffer buffer = new StringBuffer();
 				int read = 0;
@@ -184,6 +187,8 @@ public static Properties loadJZ(File file) {
 				e1.printStackTrace();
 			} catch (IOException e1) {
 				e1.printStackTrace();
+			} finally {
+				FileUtil.close(reader);
 			}
 		}
 		return props;
