Log dependency collection errors in JBoss to debug level (DataDog#5431)

smola · web-flow · commit a4bbc99abb1c · 2023-06-20T11:01:11.000+02:00
These are inocuous and confusing to users.
diff --git a/telemetry/src/main/java/datadog/telemetry/dependency/JbossVirtualFileHelper.java b/telemetry/src/main/java/datadog/telemetry/dependency/JbossVirtualFileHelper.java
@@ -93,7 +93,7 @@ public static URI getJbossVfsPath(URL location) {
             JbossVirtualFileHelper.jbossVirtualFileHelper =
                 new JbossVirtualFileHelper(connection.getClass().getClassLoader());
       } catch (Exception e) {
-        log.warn("Error preparing for inspection of jboss virtual files", e);
+        log.debug("Error preparing for inspection of jboss virtual files", e);
         return null;
       }
     }
@@ -105,7 +105,7 @@ public static URI getJbossVfsPath(URL location) {
     if (physicalFile.isFile() && physicalFile.getName().endsWith(".jar")) {
       return physicalFile.toURI();
     } else {
-      log.warn("Physical file {} is not a jar", physicalFile);
+      log.debug("Physical file {} is not a jar", physicalFile);
     }
 
     // not sure what this is about, but it's what the old code used to do

Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,7 @@ public static URI getJbossVfsPath(URL location) {`
`93`	`93`	`JbossVirtualFileHelper.jbossVirtualFileHelper =`
`94`	`94`	`new JbossVirtualFileHelper(connection.getClass().getClassLoader());`
`95`	`95`	`} catch (Exception e) {`
`96`		`- log.warn("Error preparing for inspection of jboss virtual files", e);`
	`96`	`+ log.debug("Error preparing for inspection of jboss virtual files", e);`
`97`	`97`	`return null;`
`98`	`98`	`}`
`99`	`99`	`}`
`@@ -105,7 +105,7 @@ public static URI getJbossVfsPath(URL location) {`
`105`	`105`	`if (physicalFile.isFile() && physicalFile.getName().endsWith(".jar")) {`
`106`	`106`	`return physicalFile.toURI();`
`107`	`107`	`} else {`
`108`		`- log.warn("Physical file {} is not a jar", physicalFile);`
	`108`	`+ log.debug("Physical file {} is not a jar", physicalFile);`
`109`	`109`	`}`
`110`	`110`
`111`	`111`	`// not sure what this is about, but it's what the old code used to do`