child_process: simplify send() result handling

mscdex · mscdex · commit dd83d1186970 · 2017-06-09T01:38:21.000-04:00
PR-URL: nodejs#13459 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
diff --git a/lib/internal/child_process.js b/lib/internal/child_process.js
@@ -645,16 +645,15 @@ function setupChannel(target, channel) {
           obj.postSend(handle, options, target);
       }
 
-      req.oncomplete = function() {
-        if (this.async === true)
+      if (req.async) {
+        req.oncomplete = function() {
           control.unref();
-        if (typeof callback === 'function')
-          callback(null);
-      };
-      if (req.async === true) {
+          if (typeof callback === 'function')
+            callback(null);
+        };
         control.ref();
-      } else {
-        process.nextTick(function() { req.oncomplete(); });
+      } else if (typeof callback === 'function') {
+        process.nextTick(callback, null);
       }
     } else {
       // Cleanup handle on error
