Skip to content

Commit 9a9409f

Browse files
avivkelleravivkeller
authored
test_runner: throw on invalid source map
PR-URL: nodejs#55055 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent 980b91a commit 9a9409f

7 files changed

Lines changed: 27 additions & 0 deletions

File tree

‎doc/api/errors.md‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2568,6 +2568,12 @@ disconnected socket.
25682568

25692569
A call was made and the UDP subsystem was not running.
25702570

2571+
<a id="ERR_SOURCE_MAP_CORRUPT"></a>
2572+
2573+
### `ERR_SOURCE_MAP_CORRUPT`
2574+
2575+
The source map could not be parsed because it does not exist, or is corrupt.
2576+
25712577
<a id="ERR_SOURCE_MAP_MISSING_SOURCE"></a>
25722578

25732579
### `ERR_SOURCE_MAP_MISSING_SOURCE`

‎lib/internal/errors.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1707,6 +1707,7 @@ E('ERR_SOCKET_CONNECTION_TIMEOUT',
17071707
E('ERR_SOCKET_DGRAM_IS_CONNECTED', 'Already connected', Error);
17081708
E('ERR_SOCKET_DGRAM_NOT_CONNECTED', 'Not connected', Error);
17091709
E('ERR_SOCKET_DGRAM_NOT_RUNNING', 'Not running', Error);
1710+
E('ERR_SOURCE_MAP_CORRUPT', `The source map for '%s' does not exist or is corrupt.`, Error);
17101711
E('ERR_SOURCE_MAP_MISSING_SOURCE', `Cannot find '%s' imported from the source map for '%s'`, Error);
17111712
E('ERR_SRI_PARSE',
17121713
'Subresource Integrity string %j had an unexpected %j at position %d',

‎lib/internal/test_runner/coverage.js‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ const { fileURLToPath } = require('internal/url');
3232
const { kMappings, SourceMap } = require('internal/source_map/source_map');
3333
const {
3434
codes: {
35+
ERR_SOURCE_MAP_CORRUPT,
3536
ERR_SOURCE_MAP_MISSING_SOURCE,
3637
},
3738
} = require('internal/errors');
@@ -353,6 +354,7 @@ class TestCoverage {
353354
continue;
354355
}
355356
const { data, lineLengths } = sourceMapCache[url];
357+
if (!data) throw new ERR_SOURCE_MAP_CORRUPT(url);
356358
let offset = 0;
357359
const executedLines = ArrayPrototypeMap(lineLengths, (length, i) => {
358360
const coverageLine = new CoverageLine(i + 1, offset, null, length + 1);

‎test/fixtures/test-runner/source-maps/invalid-json/index.js‎

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎test/fixtures/test-runner/source-maps/invalid-json/index.js.map‎

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎test/fixtures/test-runner/source-maps/missing-map.js‎

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎test/parallel/test-runner-coverage-source-map.js‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,4 +80,18 @@ describe('Coverage with source maps', async () => {
8080
t.assert.ok(spawned.stdout.includes(error));
8181
t.assert.strictEqual(spawned.code, 1);
8282
});
83+
84+
for (const [file, message] of [
85+
[fixtures.path('test-runner', 'source-maps', 'invalid-json', 'index.js'), 'is not valid JSON'],
86+
[fixtures.path('test-runner', 'source-maps', 'missing-map.js'), 'does not exist'],
87+
]) {
88+
await it(`should throw when a source map ${message}`, async (t) => {
89+
const spawned = await common.spawnPromisified(process.execPath, [...flags, file]);
90+
91+
const error = `The source map for '${pathToFileURL(file)}' does not exist or is corrupt`;
92+
t.assert.strictEqual(spawned.stderr, '');
93+
t.assert.ok(spawned.stdout.includes(error));
94+
t.assert.strictEqual(spawned.code, 1);
95+
});
96+
}
8397
}).then(common.mustCall());

0 commit comments

Comments
 (0)