Skip to content

Commit b3fbba5

Browse files
author
eugenp
committed
new httpclient timeout examples - old api and new api
1 parent 42b09f3 commit b3fbba5

4 files changed

Lines changed: 240 additions & 135 deletions

File tree

‎httpclient/pom.xml‎

Lines changed: 138 additions & 134 deletions
Original file line numberDiff line numberDiff line change
@@ -1,36 +1,40 @@
1-
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
2-
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
3-
<modelVersion>4.0.0</modelVersion>
4-
<groupId>org.baeldung</groupId>
5-
<artifactId>httpclient</artifactId>
6-
<version>0.1-SNAPSHOT</version>
7-
8-
<name>httpclient</name>
9-
10-
<dependencies>
11-
12-
<!-- utils -->
13-
14-
<dependency>
15-
<groupId>com.google.guava</groupId>
16-
<artifactId>guava</artifactId>
17-
<version>${guava.version}</version>
18-
</dependency>
19-
20-
<dependency>
21-
<groupId>org.apache.commons</groupId>
22-
<artifactId>commons-lang3</artifactId>
23-
<version>${commons-lang3.version}</version>
24-
</dependency>
25-
26-
<!-- http client -->
27-
28-
<dependency>
29-
<groupId>org.apache.httpcomponents</groupId>
30-
<artifactId>httpclient</artifactId>
31-
<version>${httpclient.version}</version>
32-
</dependency>
33-
1+
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
2+
<modelVersion>4.0.0</modelVersion>
3+
<groupId>org.baeldung</groupId>
4+
<artifactId>httpclient</artifactId>
5+
<version>0.1-SNAPSHOT</version>
6+
7+
<name>httpclient</name>
8+
9+
<dependencies>
10+
11+
<!-- utils -->
12+
13+
<dependency>
14+
<groupId>com.google.guava</groupId>
15+
<artifactId>guava</artifactId>
16+
<version>${guava.version}</version>
17+
</dependency>
18+
19+
<dependency>
20+
<groupId>org.apache.commons</groupId>
21+
<artifactId>commons-lang3</artifactId>
22+
<version>${commons-lang3.version}</version>
23+
</dependency>
24+
25+
<!-- http client -->
26+
27+
<dependency>
28+
<groupId>org.apache.httpcomponents</groupId>
29+
<artifactId>httpclient</artifactId>
30+
<version>${httpclient.version}</version>
31+
</dependency>
32+
<dependency>
33+
<groupId>org.apache.httpcomponents</groupId>
34+
<artifactId>httpcore</artifactId>
35+
<version>${httpcore.version}</version>
36+
</dependency>
37+
3438
<!-- logging -->
3539

3640
<dependency>
@@ -55,106 +59,106 @@
5559
<artifactId>log4j-over-slf4j</artifactId>
5660
<version>${org.slf4j.version}</version>
5761
</dependency>
58-
59-
<!-- test scoped -->
60-
61-
<dependency>
62-
<groupId>junit</groupId>
63-
<artifactId>junit-dep</artifactId>
64-
<version>${junit.version}</version>
65-
<scope>test</scope>
66-
</dependency>
67-
68-
<dependency>
69-
<groupId>org.hamcrest</groupId>
70-
<artifactId>hamcrest-core</artifactId>
71-
<version>${org.hamcrest.version}</version>
72-
<scope>test</scope>
73-
</dependency>
74-
<dependency>
75-
<groupId>org.hamcrest</groupId>
76-
<artifactId>hamcrest-library</artifactId>
77-
<version>${org.hamcrest.version}</version>
78-
<scope>test</scope>
79-
</dependency>
80-
81-
<dependency>
82-
<groupId>org.mockito</groupId>
83-
<artifactId>mockito-core</artifactId>
84-
<version>${mockito.version}</version>
85-
<scope>test</scope>
86-
</dependency>
87-
88-
</dependencies>
89-
90-
<build>
91-
<finalName>httpclient</finalName>
92-
<resources>
93-
<resource>
94-
<directory>src/main/resources</directory>
95-
<filtering>true</filtering>
96-
</resource>
97-
</resources>
98-
99-
<plugins>
100-
101-
<plugin>
102-
<groupId>org.apache.maven.plugins</groupId>
103-
<artifactId>maven-compiler-plugin</artifactId>
104-
<version>${maven-compiler-plugin.version}</version>
105-
<configuration>
106-
<source>1.7</source>
107-
<target>1.7</target>
108-
</configuration>
109-
</plugin>
110-
111-
<plugin>
112-
<groupId>org.apache.maven.plugins</groupId>
113-
<artifactId>maven-surefire-plugin</artifactId>
114-
<version>${maven-surefire-plugin.version}</version>
115-
</plugin>
116-
117-
</plugins>
118-
119-
</build>
120-
121-
<properties>
122-
<!-- Spring -->
123-
<org.springframework.version>4.0.0.RELEASE</org.springframework.version>
124-
<org.springframework.security.version>3.2.0.RELEASE</org.springframework.security.version>
125-
126-
<!-- persistence -->
127-
<hibernate.version>4.3.0.Final</hibernate.version>
128-
<mysql-connector-java.version>5.1.27</mysql-connector-java.version>
129-
130-
<!-- logging -->
131-
<org.slf4j.version>1.7.5</org.slf4j.version>
132-
<logback.version>1.0.11</logback.version>
133-
134-
<!-- various -->
135-
<hibernate-validator.version>5.0.1.Final</hibernate-validator.version>
136-
137-
<!-- util -->
138-
<guava.version>15.0</guava.version>
139-
<commons-lang3.version>3.1</commons-lang3.version>
140-
141-
<!-- testing -->
142-
<org.hamcrest.version>1.3</org.hamcrest.version>
143-
<junit.version>4.11</junit.version>
144-
<mockito.version>1.9.5</mockito.version>
145-
146-
<httpcore.version>4.3</httpcore.version>
147-
<httpclient.version>4.3.1</httpclient.version>
148-
149-
<rest-assured.version>2.1.0</rest-assured.version>
150-
151-
<!-- maven plugins -->
152-
<maven-compiler-plugin.version>3.1</maven-compiler-plugin.version>
153-
<maven-war-plugin.version>2.4</maven-war-plugin.version>
154-
<maven-surefire-plugin.version>2.16</maven-surefire-plugin.version>
155-
<maven-resources-plugin.version>2.6</maven-resources-plugin.version>
156-
<cargo-maven2-plugin.version>1.4.5</cargo-maven2-plugin.version>
157-
158-
</properties>
62+
63+
<!-- test scoped -->
64+
65+
<dependency>
66+
<groupId>junit</groupId>
67+
<artifactId>junit-dep</artifactId>
68+
<version>${junit.version}</version>
69+
<scope>test</scope>
70+
</dependency>
71+
72+
<dependency>
73+
<groupId>org.hamcrest</groupId>
74+
<artifactId>hamcrest-core</artifactId>
75+
<version>${org.hamcrest.version}</version>
76+
<scope>test</scope>
77+
</dependency>
78+
<dependency>
79+
<groupId>org.hamcrest</groupId>
80+
<artifactId>hamcrest-library</artifactId>
81+
<version>${org.hamcrest.version}</version>
82+
<scope>test</scope>
83+
</dependency>
84+
85+
<dependency>
86+
<groupId>org.mockito</groupId>
87+
<artifactId>mockito-core</artifactId>
88+
<version>${mockito.version}</version>
89+
<scope>test</scope>
90+
</dependency>
91+
92+
</dependencies>
93+
94+
<build>
95+
<finalName>httpclient</finalName>
96+
<resources>
97+
<resource>
98+
<directory>src/main/resources</directory>
99+
<filtering>true</filtering>
100+
</resource>
101+
</resources>
102+
103+
<plugins>
104+
105+
<plugin>
106+
<groupId>org.apache.maven.plugins</groupId>
107+
<artifactId>maven-compiler-plugin</artifactId>
108+
<version>${maven-compiler-plugin.version}</version>
109+
<configuration>
110+
<source>1.7</source>
111+
<target>1.7</target>
112+
</configuration>
113+
</plugin>
114+
115+
<plugin>
116+
<groupId>org.apache.maven.plugins</groupId>
117+
<artifactId>maven-surefire-plugin</artifactId>
118+
<version>${maven-surefire-plugin.version}</version>
119+
</plugin>
120+
121+
</plugins>
122+
123+
</build>
124+
125+
<properties>
126+
<!-- Spring -->
127+
<org.springframework.version>4.0.0.RELEASE</org.springframework.version>
128+
<org.springframework.security.version>3.2.0.RELEASE</org.springframework.security.version>
129+
130+
<!-- persistence -->
131+
<hibernate.version>4.3.0.Final</hibernate.version>
132+
<mysql-connector-java.version>5.1.27</mysql-connector-java.version>
133+
134+
<!-- logging -->
135+
<org.slf4j.version>1.7.5</org.slf4j.version>
136+
<logback.version>1.0.11</logback.version>
137+
138+
<!-- various -->
139+
<hibernate-validator.version>5.0.1.Final</hibernate-validator.version>
140+
141+
<!-- util -->
142+
<guava.version>15.0</guava.version>
143+
<commons-lang3.version>3.1</commons-lang3.version>
144+
145+
<!-- testing -->
146+
<org.hamcrest.version>1.3</org.hamcrest.version>
147+
<junit.version>4.11</junit.version>
148+
<mockito.version>1.9.5</mockito.version>
149+
150+
<httpcore.version>4.3.1</httpcore.version>
151+
<httpclient.version>4.3.1</httpclient.version>
152+
153+
<rest-assured.version>2.1.0</rest-assured.version>
154+
155+
<!-- maven plugins -->
156+
<maven-compiler-plugin.version>3.1</maven-compiler-plugin.version>
157+
<maven-war-plugin.version>2.4</maven-war-plugin.version>
158+
<maven-surefire-plugin.version>2.16</maven-surefire-plugin.version>
159+
<maven-resources-plugin.version>2.6</maven-resources-plugin.version>
160+
<cargo-maven2-plugin.version>1.4.5</cargo-maven2-plugin.version>
161+
162+
</properties>
159163

160164
</project>

‎httpclient/src/test/java/org/baeldung/httpclient/HttpClientTimeoutLiveTest.java‎

Lines changed: 95 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,95 @@
1+
package org.baeldung.httpclient;
2+
3+
import static org.hamcrest.Matchers.equalTo;
4+
import static org.junit.Assert.assertThat;
5+
6+
import java.io.IOException;
7+
import java.io.InputStream;
8+
9+
import org.apache.http.HttpEntity;
10+
import org.apache.http.client.ClientProtocolException;
11+
import org.apache.http.client.config.RequestConfig;
12+
import org.apache.http.client.methods.CloseableHttpResponse;
13+
import org.apache.http.client.methods.HttpGet;
14+
import org.apache.http.impl.client.CloseableHttpClient;
15+
import org.apache.http.impl.client.DefaultHttpClient;
16+
import org.apache.http.impl.client.HttpClientBuilder;
17+
import org.apache.http.params.CoreConnectionPNames;
18+
import org.apache.http.params.HttpConnectionParams;
19+
import org.apache.http.params.HttpParams;
20+
import org.junit.After;
21+
import org.junit.Test;
22+
23+
public class HttpClientTimeoutLiveTest {
24+
25+
private CloseableHttpResponse response;
26+
27+
@After
28+
public final void after() throws IllegalStateException, IOException {
29+
if (response == null) {
30+
return;
31+
}
32+
33+
try {
34+
final HttpEntity entity = response.getEntity();
35+
if (entity != null) {
36+
final InputStream instream = entity.getContent();
37+
instream.close();
38+
}
39+
} finally {
40+
response.close();
41+
}
42+
}
43+
44+
// tests
45+
46+
@SuppressWarnings("deprecation")
47+
@Test
48+
public final void givenUsingDeprecatedApi_whenSettingTimeoutViaRawParams_thenCorrect() throws ClientProtocolException, IOException {
49+
final int timeout = 2;
50+
final DefaultHttpClient client = new DefaultHttpClient();
51+
final HttpGet request = new HttpGet("http://www.github.com");
52+
53+
final HttpParams httpParams = client.getParams();
54+
httpParams.setParameter(CoreConnectionPNames.CONNECTION_TIMEOUT, timeout * 1000);
55+
httpParams.setParameter(CoreConnectionPNames.SO_TIMEOUT, timeout * 1000);
56+
// httpParams.setLongParameter(ClientPNames.CONN_MANAGER_TIMEOUT, new Long(timeout * 1000)); // https://issues.apache.org/jira/browse/HTTPCLIENT-1418
57+
58+
response = client.execute(request);
59+
60+
assertThat(response.getStatusLine().getStatusCode(), equalTo(200));
61+
client.close();
62+
}
63+
64+
@SuppressWarnings("deprecation")
65+
@Test
66+
public final void givenUsingDeprecatedApi_whenSettingTimeoutViaHigherLevelApi_thenCorrect() throws ClientProtocolException, IOException {
67+
final int timeout = 2;
68+
final DefaultHttpClient client = new DefaultHttpClient();
69+
final HttpGet request = new HttpGet("http://www.github.com");
70+
71+
final HttpParams httpParams = client.getParams();
72+
HttpConnectionParams.setConnectionTimeout(httpParams, timeout * 1000); // http.connection.timeout
73+
HttpConnectionParams.setSoTimeout(httpParams, timeout * 1000); // http.socket.timeout
74+
75+
response = client.execute(request);
76+
77+
assertThat(response.getStatusLine().getStatusCode(), equalTo(200));
78+
client.close();
79+
}
80+
81+
@Test
82+
public final void givenUsingNewApi_whenSettingTimeoutViaHighLevelApi_thenCorrect() throws ClientProtocolException, IOException {
83+
final int timeout = 5;
84+
85+
final RequestConfig.Builder requestBuilder = RequestConfig.custom().setConnectTimeout(timeout * 1000).setConnectionRequestTimeout(timeout * 1000);
86+
final CloseableHttpClient client = HttpClientBuilder.create().setDefaultRequestConfig(requestBuilder.build()).build();
87+
88+
final HttpGet request = new HttpGet("http://www.github.com");
89+
90+
response = client.execute(request);
91+
92+
assertThat(response.getStatusLine().getStatusCode(), equalTo(200));
93+
}
94+
95+
}

‎spring-security-rest-basic-auth/pom.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -294,7 +294,7 @@
294294
<mysql-connector-java.version>5.1.27</mysql-connector-java.version>
295295

296296
<!-- http -->
297-
<httpcore.version>4.3</httpcore.version>
297+
<httpcore.version>4.3.1</httpcore.version>
298298
<httpclient.version>4.3.1</httpclient.version>
299299

300300
<!-- logging -->

0 commit comments

Comments
 (0)