* aligned issue API with domain model

dlinsin · dlinsin · commit 80d2d01cdc83 · 2009-11-14T07:43:45.000+01:00
diff --git a/src/main/java/de/linsin/github/rest/domain/Issue.java b/src/main/java/de/linsin/github/rest/domain/Issue.java
@@ -26,7 +26,7 @@
  * @author David Linsin - dlinsin@gmail.com
  */
 public class Issue {
-    private long number;
+    private int number;
     private int votes;
     private String created_at;
     private String body;
@@ -68,7 +68,7 @@ public long getNumber() {
         return number;
     }
 
-    public void setNumber(long argNumber) {
+    public void setNumber(int argNumber) {
         number = argNumber;
     }
 
@@ -169,7 +169,7 @@ public boolean equals(Object o) {
 
     @Override
     public int hashCode() {
-        int result = (int) (number ^ (number >>> 32));
+        int result = number;
         result = 31 * result + votes;
         result = 31 * result + (created_at != null ? created_at.hashCode() : 0);
         result = 31 * result + (body != null ? body.hashCode() : 0);
diff --git a/src/test/java/de/linsin/github/rest/service/IssueBrowserIntegrationTest.java b/src/test/java/de/linsin/github/rest/service/IssueBrowserIntegrationTest.java
@@ -242,7 +242,7 @@ public void close_issue_invalid_number() {
         Repository repo = setupTestRepo();
         Issue issue = setUpTestIssue(repo);
         Issue newIssue = new Issue();
-        newIssue.setNumber(99999L);
+        newIssue.setNumber(99999);
         try {
             classUnderTest.close(repo, newIssue);
             fail("expected exception");
@@ -290,7 +290,7 @@ public void reopen_issue_invalid_number() {
         Repository repo = setupTestRepo();
         Issue issue = setUpClosedTestIssue(repo);
         Issue newIssue = new Issue();
-        newIssue.setNumber(99999L);
+        newIssue.setNumber(99999);
         try {
             classUnderTest.close(repo, newIssue);
             fail("expected exception");
diff --git a/src/test/java/de/linsin/github/rest/service/IssueBrowserTest.java b/src/test/java/de/linsin/github/rest/service/IssueBrowserTest.java
@@ -194,7 +194,7 @@ public void open_issue_null_repo_passed() {
     public void close_issue() {
         Repository repo = setupTestRepo();
         Issue issue = new Issue();
-        issue.setNumber(1L);
+        issue.setNumber(1);
         expect(mockRestTemplate.postForObject(eq(IssueBrowser.CLOSE_ISSUE_URL), anyObject(), eq(IssueResponse.class), eq(repo.getOwner()),
                 eq(repo.getName()), eq(String.valueOf(issue.getNumber())))).andReturn(new IssueResponse());
         replay(mockRestTemplate);
@@ -215,15 +215,15 @@ public void close_issue_null_issue_passed() {
     @Test(expected = NullPointerException.class)
     public void close_issue_null_repo_passed() {
         Issue issue = new Issue();
-        issue.setNumber(1L);
+        issue.setNumber(1);
         classUnderTest.close(null, issue);
     }
 
     @Test
     public void reopen_issue() {
         Repository repo = setupTestRepo();
         Issue issue = new Issue();
-        issue.setNumber(1L);
+        issue.setNumber(1);
         IssueResponse response = new IssueResponse();
         response.setIssue(issue);
         expect(mockRestTemplate.postForObject(eq(IssueBrowser.REOPEN_ISSUE_URL), anyObject(), eq(IssueResponse.class), eq(repo.getOwner()),
@@ -246,7 +246,7 @@ public void reopen_issue_null_issue_passed() {
     @Test(expected = NullPointerException.class)
     public void reopen_issue_null_repo_passed() {
         Issue issue = new Issue();
-        issue.setNumber(1L);
+        issue.setNumber(1);
         classUnderTest.reopen(null, issue);
     }
 
