fix indexing bug in constructor (msgpack#525)

Minh-Ng · web-flow · commit 0348a49e7a44 · 2020-08-31T11:23:20.000-07:00
fix ValueFactory.newMap(Entry&lt;Value, Value&gt;...pairs), which is currently iterating by 2 when it should be iterating through each passed in pair.
diff --git a/msgpack-core/src/main/java/org/msgpack/value/ValueFactory.java b/msgpack-core/src/main/java/org/msgpack/value/ValueFactory.java
@@ -232,7 +232,7 @@ public static ImmutableMapValue emptyMap()
     public static MapValue newMap(Map.Entry<? extends Value, ? extends Value>... pairs)
     {
         Value[] kvs = new Value[pairs.length * 2];
-        for (int i = 0; i < pairs.length; i += 2) {
+        for (int i = 0; i < pairs.length; ++i) {
             kvs[i * 2] = pairs[i].getKey();
             kvs[i * 2 + 1] = pairs[i].getValue();
         }

Original file line number	Diff line number	Diff line change
`@@ -232,7 +232,7 @@ public static ImmutableMapValue emptyMap()`
`232`	`232`	`public static MapValue newMap(Map.Entry<? extends Value, ? extends Value>... pairs)`
`233`	`233`	`{`
`234`	`234`	`Value[] kvs = new Value[pairs.length * 2];`
`235`		`- for (int i = 0; i < pairs.length; i += 2) {`
	`235`	`+ for (int i = 0; i < pairs.length; ++i) {`
`236`	`236`	`kvs[i * 2] = pairs[i].getKey();`
`237`	`237`	`kvs[i * 2 + 1] = pairs[i].getValue();`
`238`	`238`	`}`