remove default factory setter

xerial · xerial · commit b391406a9da1 · 2016-01-04T13:46:37.000+09:00
diff --git a/msgpack-core/src/main/java/org/msgpack/core/MessagePack.java b/msgpack-core/src/main/java/org/msgpack/core/MessagePack.java
@@ -28,27 +28,14 @@ public class MessagePack
 {
     public static final Charset UTF8 = Charset.forName("UTF-8");
 
-    private static MessagePackFactory defaultFactory = new MessagePackFactory();
-
-    /**
-     * Sets the default configuration used for the static constructor methods of this MessagePack class.
-     */
-    public static void setDefaultFactory(MessagePackFactory newDefaultFactory)
-    {
-        defaultFactory = newDefaultFactory;
-    }
-
-    public static MessagePackFactory getDefaultFactory()
-    {
-        return defaultFactory;
-    }
+    private final static MessagePackFactory defaultFactory = new MessagePackFactory();
 
     private MessagePack()
     {
     }
 
     /**
-     * Equivalent to getDefaultFactory().newPacker(out).
+     * Equivalent to defaultFactory().newPacker(out).
      *
      * @param out
      * @return
@@ -59,7 +46,7 @@ public static MessagePacker newDefaultPacker(OutputStream out)
     }
 
     /**
-     * Equivalent to getDefaultFactory().newPacker(channel).
+     * Equivalent to defaultFactory().newPacker(channel).
      *
      * @param channel
      * @return
@@ -70,7 +57,7 @@ public static MessagePacker newDefaultPacker(WritableByteChannel channel)
     }
 
     /**
-     * Equivalent to getDefaultFactory().newBufferPacker()
+     * Equivalent to defaultFactory().newBufferPacker()
      *
      * @return
      */
@@ -80,7 +67,7 @@ public static MessageBufferPacker newDefaultBufferPacker()
     }
 
     /**
-     * Equivalent to getDefaultFactory().newUnpacker(in).
+     * Equivalent to defaultFactory().newUnpacker(in).
      *
      * @param in
      * @return
@@ -91,7 +78,7 @@ public static MessageUnpacker newDefaultUnpacker(InputStream in)
     }
 
     /**
-     * Equivalent to getDefaultFactory().newUnpacker(channel).
+     * Equivalent to defaultFactory().newUnpacker(channel).
      *
      * @param channel
      * @return
@@ -102,7 +89,7 @@ public static MessageUnpacker newDefaultUnpacker(ReadableByteChannel channel)
     }
 
     /**
-     * Equivalent to getDefaultFactory().newUnpacker(contents).
+     * Equivalent to defaultFactory().newUnpacker(contents).
      *
      * @param contents
      * @return
@@ -113,7 +100,7 @@ public static MessageUnpacker newDefaultUnpacker(byte[] contents)
     }
 
     /**
-     * Equivalent to getDefaultFactory().newUnpacker(contents, offset, length).
+     * Equivalent to defaultFactory().newUnpacker(contents, offset, length).
      *
      * @param contents
      * @param offset
diff --git a/msgpack-core/src/main/java/org/msgpack/core/MesssagePackerConfig.java b/msgpack-core/src/main/java/org/msgpack/core/MesssagePackerConfig.java
@@ -0,0 +1,8 @@
+package org.msgpack.core;
+
+/**
+ *
+ */
+public class MesssagePackerConfig
+{
+}

Original file line number	Diff line number	Diff line change
`@@ -28,27 +28,14 @@ public class MessagePack`
`28`	`28`	`{`
`29`	`29`	`public static final Charset UTF8 = Charset.forName("UTF-8");`
`30`	`30`
`31`		`- private static MessagePackFactory defaultFactory = new MessagePackFactory();`
`32`		`-`
`33`		`- /**`
`34`		`- * Sets the default configuration used for the static constructor methods of this MessagePack class.`
`35`		`- */`
`36`		`- public static void setDefaultFactory(MessagePackFactory newDefaultFactory)`
`37`		`- {`
`38`		`- defaultFactory = newDefaultFactory;`
`39`		`- }`
`40`		`-`
`41`		`- public static MessagePackFactory getDefaultFactory()`
`42`		`- {`
`43`		`- return defaultFactory;`
`44`		`- }`
	`31`	`+ private final static MessagePackFactory defaultFactory = new MessagePackFactory();`
`45`	`32`
`46`	`33`	`private MessagePack()`
`47`	`34`	`{`
`48`	`35`	`}`
`49`	`36`
`50`	`37`	`/**`
`51`		`- * Equivalent to getDefaultFactory().newPacker(out).`
	`38`	`+ * Equivalent to defaultFactory().newPacker(out).`
`52`	`39`	`*`
`53`	`40`	`* @param out`
`54`	`41`	`* @return`
`@@ -59,7 +46,7 @@ public static MessagePacker newDefaultPacker(OutputStream out)`
`59`	`46`	`}`
`60`	`47`
`61`	`48`	`/**`
`62`		`- * Equivalent to getDefaultFactory().newPacker(channel).`
	`49`	`+ * Equivalent to defaultFactory().newPacker(channel).`
`63`	`50`	`*`
`64`	`51`	`* @param channel`
`65`	`52`	`* @return`
`@@ -70,7 +57,7 @@ public static MessagePacker newDefaultPacker(WritableByteChannel channel)`
`70`	`57`	`}`
`71`	`58`
`72`	`59`	`/**`
`73`		`- * Equivalent to getDefaultFactory().newBufferPacker()`
	`60`	`+ * Equivalent to defaultFactory().newBufferPacker()`
`74`	`61`	`*`
`75`	`62`	`* @return`
`76`	`63`	`*/`
`@@ -80,7 +67,7 @@ public static MessageBufferPacker newDefaultBufferPacker()`
`80`	`67`	`}`
`81`	`68`
`82`	`69`	`/**`
`83`		`- * Equivalent to getDefaultFactory().newUnpacker(in).`
	`70`	`+ * Equivalent to defaultFactory().newUnpacker(in).`
`84`	`71`	`*`
`85`	`72`	`* @param in`
`86`	`73`	`* @return`
`@@ -91,7 +78,7 @@ public static MessageUnpacker newDefaultUnpacker(InputStream in)`
`91`	`78`	`}`
`92`	`79`
`93`	`80`	`/**`
`94`		`- * Equivalent to getDefaultFactory().newUnpacker(channel).`
	`81`	`+ * Equivalent to defaultFactory().newUnpacker(channel).`
`95`	`82`	`*`
`96`	`83`	`* @param channel`
`97`	`84`	`* @return`
`@@ -102,7 +89,7 @@ public static MessageUnpacker newDefaultUnpacker(ReadableByteChannel channel)`
`102`	`89`	`}`
`103`	`90`
`104`	`91`	`/**`
`105`		`- * Equivalent to getDefaultFactory().newUnpacker(contents).`
	`92`	`+ * Equivalent to defaultFactory().newUnpacker(contents).`
`106`	`93`	`*`
`107`	`94`	`* @param contents`
`108`	`95`	`* @return`
`@@ -113,7 +100,7 @@ public static MessageUnpacker newDefaultUnpacker(byte[] contents)`
`113`	`100`	`}`
`114`	`101`
`115`	`102`	`/**`
`116`		`- * Equivalent to getDefaultFactory().newUnpacker(contents, offset, length).`
	`103`	`+ * Equivalent to defaultFactory().newUnpacker(contents, offset, length).`
`117`	`104`	`*`
`118`	`105`	`* @param contents`
`119`	`106`	`* @param offset`
-Original file line number
+Diff line change
@@ @@ -0,0 +1,8 @@ @@
 +package org.msgpack.core;
++
 +/**
 + *
 + */
 +public class MesssagePackerConfig
 +{
 +}