You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
docs: Add short section about github actions (feast-dev#2315)
* Add short section about github actions
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
* Move to contributing.md
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+23-8Lines changed: 23 additions & 8 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -20,12 +20,12 @@ A quick list of things to keep in mind as you're making changes:
20
20
- When you make the PR
21
21
- Make a pull request from the forked repo you made
22
22
- Ensure you add a GitHub **label** (i.e. a kind tag to the PR (e.g. `kind/bug` or `kind/housekeeping`)) or else checks will fail.
23
-
- Ensure you leave a release note for any user facing changes in the PR. There is a field automatically generated in the PR request. You can write `NONE` in that field if there are no user facing changes.
23
+
- Ensure you leave a release note for any user facing changes in the PR. There is a field automatically generated in the PR request. You can write `NONE` in that field if there are no user facing changes.
24
24
- Please run tests locally before submitting a PR (e.g. for Python, the [local integration tests](#local-integration-tests))
25
25
- Try to keep PRs smaller. This makes them easier to review.
26
26
27
27
### Forking the repo
28
-
Fork the Feast Github repo and clone your fork locally. Then make changes to a local branch to the fork.
28
+
Fork the Feast Github repo and clone your fork locally. Then make changes to a local branch to the fork.
29
29
30
30
See [Creating a pull request from a fork](https://docs.github.com/en/github/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork)
> and commenting out tests that are added to `DEFAULT_FULL_REPO_CONFIGS`
135
135
@@ -187,4 +187,19 @@ go vet
187
187
Unit tests for the Feast Go Client can be run as follows:
188
188
```sh
189
189
go test
190
-
```
190
+
```
191
+
192
+
### Testing with Github Actions workflows
193
+
* Update your current master on your forked branch and make a pull request against your own forked master.
194
+
* Enable workflows by going to actions and clicking `Enable Workflows`.
195
+
* Pushes will now run your edited workflow yaml file against your test code.
196
+
* Unfortunately, in order to test any github workflow changes, you must push the code to the branch and see the output in the actions tab.
197
+
198
+
## Issues
199
+
* pr-integration-tests workflow is skipped
200
+
* Add `ok-to-test` github label.
201
+
* pr-integration-tests errors out with `Error: fatal: invalid refspec '+refs/pull//merge:refs/remotes/pull//merge'`
202
+
* This is because github actions cannot pull the branch version for some reason so just find your PR number in your pull request header and hard code it into the `uses: actions/checkout@v2` section (i.e replace `refs/pull/${{ github.event.pull_request.number }}/merge` with `refs/pull/<pr number>/merge`)
203
+
* AWS/GCP workflow
204
+
* Currently still cannot test GCP/AWS workflow without setting up secrets in a forked repository.
Copy file name to clipboardExpand all lines: docs/how-to-guides/adding-or-reusing-tests.md
-1Lines changed: 0 additions & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -202,4 +202,3 @@ Starting 6006
202
202
* You should be able to run the integration tests and have the redis cluster tests pass.
203
203
* If you would like to run your own redis cluster, you can run the above commands with your own specified ports and connect to the newly configured cluster.
204
204
* To stop the cluster, run `./create-cluster stop` and then `./create-cluster clean`.
0 commit comments