http: avoid duplicate isArray()

mscdex · Italo A. Casas · commit 6add7f70fe13 · 2017-01-24T22:33:12.000-05:00
PR-URL: nodejs#10654 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
diff --git a/lib/_http_client.js b/lib/_http_client.js
@@ -111,7 +111,8 @@ function ClientRequest(options, cb) {
     self.once('response', cb);
   }
 
-  if (!Array.isArray(options.headers)) {
+  var headersArray = Array.isArray(options.headers);
+  if (!headersArray) {
     if (options.headers) {
       var keys = Object.keys(options.headers);
       for (var i = 0, l = keys.length; i < l; i++) {
@@ -155,7 +156,7 @@ function ClientRequest(options, cb) {
     self.useChunkedEncodingByDefault = true;
   }
 
-  if (Array.isArray(options.headers)) {
+  if (headersArray) {
     self._storeHeader(self.method + ' ' + self.path + ' HTTP/1.1\r\n',
                       options.headers);
   } else if (self.getHeader('expect')) {
