Skip to content

PCD padding/large-count safety and FillHoles orientation fixes #7627

Open

Description

@rishidevde

Summary

This report tracks three narrowly scoped Open3D defects addressed by the accompanying patch:

  1. PCD padding fields can crash or corrupt reads when a PCD contains a field named _ used only for alignment/padding. The reader should consume the bytes but must not create or write to a point attribute named _.
  2. PCD point/index arithmetic uses 32-bit integers in several read paths. Large point counts can overflow when calculating row offsets and destination indices.
  3. Tensor TriangleMesh::FillHoles can return incorrectly oriented filled triangles. The resulting mesh may have inconsistent winding and inverted normals on newly filled faces.

Proposed fix

The patch:

  • skips _ padding fields during attribute initialization and decoding;
  • uses std::int64_t for point counts, row sizes, offsets, and decode indices;
  • runs VTK consistency/auto-orientation after vtkFillHolesFilter;
  • adds focused regression tests for padding-field reads and hole-fill orientation.

Validation

The focused native C++ test binary is still being built with x64 MSVC. The PR will report the exact test command and result once the build completes. The current branch contains only the four source/test files required for this change.

Related upstream reports: #6437, #7402, and #6681.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions