Skip to content

fix: Edit on GitHub link to point to source .py files for API docs'#15256

Draft
Aanushka001 wants to merge 3 commits into
ipython:mainfrom
Aanushka001:fix-edit-on-github-link
Draft

fix: Edit on GitHub link to point to source .py files for API docs'#15256
Aanushka001 wants to merge 3 commits into
ipython:mainfrom
Aanushka001:fix-edit-on-github-link

Conversation

@Aanushka001

Copy link
Copy Markdown

'Replaces closed PR #15231 with only the correct changes

@Aanushka001

Copy link
Copy Markdown
Author

@Carreau this supersedes the closed PR #15231, the sphinxf typo has been fixed and all checks are passing now. Would appreciate a review!

Comment thread docs/source/conf.py

# - template_path: Add any paths that contain templates here, relative to this directory.
# - master_doc: The master toctree document.
# - master_doc: The master tocture document.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong and unrealated change

Comment thread docs/source/conf.py
Comment on lines +116 to +124
# Add any paths that contain custom static files (such as style sheets) here,
# relative to this directory. They are copied after the builtin static files,
# so a file named "default.css" will overwrite the builtin "default.css".
# Favicon needs the directory name
# - html_favicon
# - html_last_updated_fmt = config["html"]["html_last_updated_fmt"]
# If not '', a 'Last updated on:' timestamp is inserted at every page bottom,
# using the given strftime format.
# Output file base name for HTML help builder.
# If not '', a 'Last updated on:' timestamp is inserted at every page bottom,
# using the given strftime format.
# Output file base name for HTML help builder.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UNrelated and unnecessary change

Comment thread docs/source/conf.py
# --------------------------
# Options for textinfo output
# ---------------------------
texinfo_documents = [

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong.

Comment thread docs/source/conf.py
]

#########################################################################
############################################################

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why ?

Comment thread docs/source/conf.py
"""



Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated.

Comment thread docs/source/conf.py
As we autogenerate configuration traits from, subclasses have lots of
duplication and we want to silence them. Indeed we build on travis with
warnings-as-error set to True, so those duplicate items make the build fail.
duplication and we want to silence them. Indeeds we build on travis with

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeeds?

Maybe or for warnings-as-errors, it's fair, but unrelated.

@Carreau

Carreau commented Jun 13, 2026

Copy link
Copy Markdown
Member

same comment as last time; there are a number of unrelated and incorrect changes. If you have issues fixing it with git, and I can show you, or do it for you.

@Carreau Carreau marked this pull request as draft June 13, 2026 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants