Repository navigation
bug: Overlays override id assigned through htmlAttributes #29712
Description
Prerequisites
- I have read the Contributing Guidelines.
- I agree to follow the Code of Conduct.
- I have searched for existing issues that already report this problem, without success.
Ionic Framework Version
v8.x
Current Behavior
Split from: #29704
In Ionic v8, overlays are overriding the id specified in the htmlAttributes with the incremental overlay ID assigned by Ionic Framework.
Applies to: modal, popover, action-sheet, loading, picker-legacy and toast.
Expected Behavior
Ionic's overlay should not assign the incremental overlay ID if the overlay already has an ID assigned to it by either the id attribute directly or the htmlAttributes.
Steps to Reproduce
- Create a new overlay, giving it a custom ID through
htmlAttributes - Observe that the overlay does not have the custom ID
This applies to all overlays except ion-alert, which has been resolved: #29708
For the reproduction URL we can either use the original reproduction and replace the alert with another overlay or assign htmlAttributes with an id property to any other overlay to observe the problem.
Code Reproduction URL
N/A
Ionic Info
N/A - reproduces in Ionic v8+.
Additional Information
No response
Activity
ionitron-bot commentedon Jul 15, 2024
This issue has been labeled as
help wanted. This label is added to issues that we believe would be good for contributors.If you'd like to work on this issue, please comment here letting us know that you would like to submit a pull request for it. This helps us to keep track of the pull request and make sure there isn't duplicated effort.
For a guide on how to create a pull request and test this project locally to see your changes, see our contributing documentation.
Thank you!
sean-perkins commentedon Jul 15, 2024
If anyone from the community is interesting in contributing, you can reference #29708 for the changes required to fix this issue (same approach would be applied to other overlays) and the test code to validate the fix.
mikelhamer commentedon Jul 17, 2024
I'm going to pick this up and start work!
fix(overlays): do not overwrite id set in htmlAttributes (#29722)
ionitron-bot commentedon Aug 23, 2024
Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.