Skip to content

doc(ion-searchbar): Vue needs kebab-case for the component attributes#19625

Merged
brandyscarney merged 7 commits into
ionic-team:masterfrom
zwacky:fix/ion-searchbar-docs
Nov 7, 2019
Merged

doc(ion-searchbar): Vue needs kebab-case for the component attributes#19625
brandyscarney merged 7 commits into
ionic-team:masterfrom
zwacky:fix/ion-searchbar-docs

Conversation

@zwacky

@zwacky zwacky commented Oct 11, 2019

Copy link
Copy Markdown
Contributor

Vue templates render the attributes as all lowercase. e.g.:

<template>
    <ion-searchbar showCancelButton="always" />
</template>

results in

<ion-searchbar showcancelbutton="always"></ion-searchbar>

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

@ionitron-bot ionitron-bot Bot added the package: core @ionic/core package label Oct 11, 2019
@brandyscarney

brandyscarney commented Oct 15, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

Sorry I accidentally removed your change by running build. For the future, our usage changes need to be made in the usage/ folder and then npm run build should be ran inside of core in order to generate it in the readme. 🙂 I went ahead and pushed a commit for this though & will merge when the build passes.

Thank you for the PR!

@zwacky

zwacky commented Oct 15, 2019

Copy link
Copy Markdown
Contributor Author

Gotcha, thanks for claryfing. Cheers

@weekly-digest weekly-digest Bot mentioned this pull request Oct 18, 2019
Closed
@brandyscarney brandyscarney merged commit c5be883 into ionic-team:master Nov 7, 2019
@brandyscarney

brandyscarney commented Nov 7, 2019

Copy link
Copy Markdown
Member

Thanks again! Sorry it took so long I had to get back over to it to update from master to fix the build. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandyscarney brandyscarney brandyscarney approved these changes

Assignees

No one assigned

Labels

package: core @ionic/core package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zwacky @brandyscarney @liamdebeasi @simon-wicki