Closed
Conversation
Fishrock123
pushed a commit
that referenced
this pull request
Apr 4, 2015
PR-URL: #1342 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Contributor
|
Thanks! Landed in bde2b3e |
Member
|
This was not a typo.. The |
Contributor
|
Oh, I thought that was only for methods on a prototype (i.e. overwitable / meant to be overwritable) 77c2da1 referred to it as |
Contributor
|
Yay rubyisms! |
Contributor
Author
|
Sorry, I didn't know. I think I should ask before make a PR. Thanks so much for clarification and I created a PR with a revert for this PR. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Creating the weekly update from the Evangelism group we found a typo problem in the Changelog. See nodejs/evangelism#52 for discussion.
Thanks