Conversation
|
LGTM |
|
Hm, this obscures the items below the fold on the left hand sidebar, without giving any visual indication that the area is scrollable. If we add some kind of visual indicator of scroll-ability, I'd be a bit more amenable to this. That said, I'm curious: do folks find themselves switching between sections of the docs often? Is this a behavior we want to optimize for? |
|
I've found myself wanting it more than a few times, as some doc pages like crypto are very long. I'd like it 👍 |
|
@chrisdickinson invisible inactive scrollbars is an OS X only issue, other platforms show them all the time, but some sort of indicator could be in order. How do you like something like this: #column2.interior:after {
content: '';
position: fixed;
bottom: 0;
width: 234px;
height: 5em;
background: linear-gradient(rgba(242,245,240, 0), rgba(242,245,240, 1));
}
#column2 ul {
padding-bottom: 5em;
}
Gradient would bump us to IE10, but I think this counts as a graceful degradation case, as Windows has always visible scrollbars. |
|
Yep, that's perfect! LGTM with that addition. |
|
@brendanashworth can i get your LGTM on the fade-out? |
There was a problem hiding this comment.
I'm not a big fan of how large this padding is, could we do with something smaller, maybe 2em?
There was a problem hiding this comment.
Unfortunately it needs to be big now with the gradient, or else items would still be faded out when scrolled to the end. I think 4em is the lower limit, I'll experiment a bit.
|
Besides the padding nit, this LGTM |
|
Went with 4em, with the gradient being 5em. The fading isn't really noticeable at the bottom this way. |
This lets the doc sidebar have its own scrolling container, making the page easier to navigate in cases where previously the menu was scrolled far off. PR-URL: #1274 Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com> Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
|
landed in 19641b1 |
Small usability change for the doc website here.
This lets the navigation sidebar have its own scrollable area, so it always stays on screen, making it easier to navigate from section to section, especially when the page itself is scrolled off by many screens, which would otherwise require the user to scroll to the far top to navigate to another section.
Should work in IE7 and above (The limiting factor being
position:fixed).cc: @chrisdickinson