benchmark: fix chunky client benchmark execution#1257
Closed
mscdex wants to merge 1 commit intonodejs:v1.xfrom
Closed
benchmark: fix chunky client benchmark execution#1257mscdex wants to merge 1 commit intonodejs:v1.xfrom
mscdex wants to merge 1 commit intonodejs:v1.xfrom
Conversation
Contributor
Author
|
It seems there is another issue yet.... fix coming soon. |
536a797 to
b3b6fa0
Compare
This commit fixes a few things for this benchmark: 1. Ensures the temporary directory for the unix socket exists. 2. Prevents the client code from being run directly because the server script is the one that calls out the client code. 3. Ensures the server is closed once the client benchmarks have finished. 4. Since this is an http benchmark, it should be moved to the http benchmarks subdirectory.
b3b6fa0 to
4e9b2b0
Compare
Contributor
Author
|
Ok it should be sorted out now. |
Contributor
|
LGTM |
mscdex
added a commit
that referenced
this pull request
Apr 3, 2015
This commit fixes a few things for this benchmark: 1. Ensures the temporary directory for the unix socket exists. 2. Prevents the client code from being run directly because the server script is the one that calls out the client code. 3. Ensures the server is closed once the client benchmarks have finished. 4. Since this is an http benchmark, it should be moved to the http benchmarks subdirectory. PR-URL: #1257 Reviewed-By: Roman Reiss <me@silverwind.io>
Contributor
Author
|
Landed in a081c7c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes a few things for this benchmark: