Skip to content

fix: flutterfire configure command when existing firebase_options.dart has a wrong format - #424

Merged
russellwheatley merged 4 commits into
invertase:mainfrom
nilsreichardt:fix-error-for-broken-files
Mar 31, 2026
Merged

fix: flutterfire configure command when existing firebase_options.dart has a wrong format#424
russellwheatley merged 4 commits into
invertase:mainfrom
nilsreichardt:fix-error-for-broken-files

Conversation

@nilsreichardt

@nilsreichardt nilsreichardt commented Feb 26, 2026

Copy link
Copy Markdown
Contributor

Description

If the repository already had a firebase_options.dart file, the flutterfire configure commend expected a specific format. If this file had a different format, the flutterfire configure . command failed.

As described in #422 the example of flutter/ai repository has this firebase_options.dart:

// File normally generated by FlutterFire CLI. This is a stand-in.
// See README.md for details.
import 'package:firebase_core/firebase_core.dart' show FirebaseOptions;

class DefaultFirebaseOptions {
  // TODO: Remove this file and run `flutterfire config` for Firebase options
  static FirebaseOptions get currentPlatform {
    throw UnimplementedError(
      'Generate this file by running `flutterfire configure`. '
      'See README.md for details.',
    );
  }
}

Source: https://github.com/flutter/ai/blob/fd3d6d7936f503e9e53d91564cb280263083c1bf/example/lib/firebase_options.dart

Before this PR, the flutterfire configure command couldn't handle this firebase_options.dart file.

Closes #422

Type of Change

  • ✨ feat -- New feature (non-breaking change which adds functionality)
  • 🛠️ fix -- Bug fix (non-breaking change which fixes an issue)
  • ❌ ! -- Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 refactor -- Code refactor
  • ✅ ci -- Build configuration change
  • 📝 docs -- Documentation
  • 🗑️ chore -- Chore

@nilsreichardt nilsreichardt mentioned this pull request Feb 26, 2026
Closed
1 task done
@russellwheatley

russellwheatley commented Mar 30, 2026

Copy link
Copy Markdown
Member

/gemini review

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Mar 30, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves the robustness of the Firebase configuration file generation by allowing the CLI to regenerate the file if it detects placeholder content (e.g., UnimplementedError). It introduces a helper method _buildConfigurationFile to centralize the generation logic and adds a regression test to verify that placeholder files are correctly replaced. The review feedback suggests applying the formatList utility within the new helper method to ensure consistent file formatting, which has been incorporated into the suggested improvement.

Comment thread packages/flutterfire_cli/lib/src/firebase/firebase_dart_configuration_write.dart
@russellwheatley

russellwheatley commented Mar 31, 2026

Copy link
Copy Markdown
Member

@nilsreichardt - thank you for PR, sorry for the delay. I'll merge once it goes green 🙏

@russellwheatley
russellwheatley merged commit 3edb907 into invertase:main Mar 31, 2026
7 checks passed
@russellwheatley russellwheatley mentioned this pull request Mar 31, 2026
Closed
1 of 7 tasks
@russellwheatley russellwheatley mentioned this pull request Apr 23, 2026
Merged

This branch was previously deployed

1 inactive deployment
CI Environment — b5031c07 Deployed Mar 31, 2026 by russellwheatley via test_linux #13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@russellwheatley russellwheatley russellwheatley approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[bug]: Exception: UnsupportedError not found in android

2 participants

@nilsreichardt @russellwheatley