fixing broken Contacts update method (#311)

kevindeleon · web-flow · commit acb9f2084332 · 2020-08-06T10:10:08.000+02:00
* fixing broken update method

"update" should follow the same pattern as other methods like deleteContact and getContact that require "id" based on the API documentation.

* updates tests and README for broken Contact method
diff --git a/README.md b/README.md
@@ -66,7 +66,7 @@ $client->contacts->create([
 ]);
 
 /** Update a contact */
-$client->contacts->update([
+$client->contacts->update("570680a8a1bcbca8a90001b9", [
     "email" => "test@example.com",
     "custom_attributes" => ['foo' => 'bar']
 ]);
diff --git a/src/IntercomContacts.php b/src/IntercomContacts.php
@@ -24,13 +24,15 @@ public function create(array $options)
      * Updates a Contact.
      *
      * @see    https://developers.intercom.com/intercom-api-reference/reference#update-contact
+     * @param  string $id
      * @param  array $options
      * @return stdClass
      * @throws Exception
      */
-    public function update(array $options)
+    public function update(string $id, array $options)
     {
-        return $this->client->put("contacts", $options);
+        $path = $this->contactPath($id);
+        return $this->client->put($path, $options);
     }
 
     /**
diff --git a/test/IntercomContactsTest.php b/test/IntercomContactsTest.php
@@ -20,7 +20,7 @@ public function testContactUpdate()
         $this->client->method('put')->willReturn('foo');
 
         $contacts = new IntercomContacts($this->client);
-        $this->assertSame('foo', $contacts->update([]));
+        $this->assertSame('foo', $contacts->update('', []));
     }
 
     public function testContactsGet()

Original file line number	Diff line number	Diff line change
`@@ -24,13 +24,15 @@ public function create(array $options)`
`24`	`24`	`* Updates a Contact.`
`25`	`25`	`*`
`26`	`26`	`* @see https://developers.intercom.com/intercom-api-reference/reference#update-contact`
	`27`	`+ * @param string $id`
`27`	`28`	`* @param array $options`
`28`	`29`	`* @return stdClass`
`29`	`30`	`* @throws Exception`
`30`	`31`	`*/`
`31`		`- public function update(array $options)`
	`32`	`+ public function update(string $id, array $options)`
`32`	`33`	`{`
`33`		`- return $this->client->put("contacts", $options);`
	`34`	`+ $path = $this->contactPath($id);`
	`35`	`+ return $this->client->put($path, $options);`
`34`	`36`	`}`
`35`	`37`
`36`	`38`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ public function testContactUpdate()`
`20`	`20`	`$this->client->method('put')->willReturn('foo');`
`21`	`21`
`22`	`22`	`$contacts = new IntercomContacts($this->client);`
`23`		`- $this->assertSame('foo', $contacts->update([]));`
	`23`	`+ $this->assertSame('foo', $contacts->update('', []));`
`24`	`24`	`}`
`25`	`25`
`26`	`26`	`public function testContactsGet()`