Apache HTTP client hates to have the Content-Length set

Dave Syer · Dave Syer · commit 5244db430058 · 2016-02-03T09:56:01.000Z
It always sets the header itself and if we set it as well it barfs
so it is better just to avoid setting it at all.
diff --git a/httpclient/src/main/java/feign/httpclient/ApacheHttpClient.java b/httpclient/src/main/java/feign/httpclient/ApacheHttpClient.java
@@ -118,10 +118,9 @@ HttpUriRequest toHttpUriRequest(Request request, Request.Options options) throws
         hasAcceptHeader = true;
       }
 
-      if (headerName.equalsIgnoreCase(Util.CONTENT_LENGTH) &&
-              requestBuilder.getHeaders(headerName) != null) {
-        //if the 'Content-Length' header is already present, it's been set from HttpEntity, so we
-        //won't add it again
+      if (headerName.equalsIgnoreCase(Util.CONTENT_LENGTH)) {
+        // The 'Content-Length' header is always set by the Apache client and it
+        // doesn't like us to set it as well.
         continue;
       }
 

Original file line number	Diff line number	Diff line change
`@@ -118,10 +118,9 @@ HttpUriRequest toHttpUriRequest(Request request, Request.Options options) throws`
`118`	`118`	`hasAcceptHeader = true;`
`119`	`119`	`}`
`120`	`120`
`121`		`- if (headerName.equalsIgnoreCase(Util.CONTENT_LENGTH) &&`
`122`		`- requestBuilder.getHeaders(headerName) != null) {`
`123`		`- //if the 'Content-Length' header is already present, it's been set from HttpEntity, so we`
`124`		`- //won't add it again`
	`121`	`+ if (headerName.equalsIgnoreCase(Util.CONTENT_LENGTH)) {`
	`122`	`+ // The 'Content-Length' header is always set by the Apache client and it`
	`123`	`+ // doesn't like us to set it as well.`
`125`	`124`	`continue;`
`126`	`125`	`}`
`127`	`126`