net: ensure WriteWrap references the handle

indutny · indutny · commit 146bea1c14e1 · 2015-05-02T17:32:29.000+02:00
`StreamBase::AfterWrite` is passing handle as an argument to the `afterWrite` function in net.js. Thus GC should not collect the handle and the request separately and assume that they are tied together. With this commit - request will always outlive the StreamBase instance, helping us survive the GC pass. Fix: nodejs#1580
diff --git a/lib/net.js b/lib/net.js
@@ -627,6 +627,7 @@ Socket.prototype._writeGeneric = function(writev, data, encoding, cb) {
   }
 
   var req = new WriteWrap();
+  req.handle = this._handle;
   req.oncomplete = afterWrite;
   req.async = false;
   var err;

Original file line number	Diff line number	Diff line change
`@@ -627,6 +627,7 @@ Socket.prototype._writeGeneric = function(writev, data, encoding, cb) {`
`627`	`627`	`}`
`628`	`628`
`629`	`629`	`var req = new WriteWrap();`
	`630`	`+ req.handle = this._handle;`
`630`	`631`	`req.oncomplete = afterWrite;`
`631`	`632`	`req.async = false;`
`632`	`633`	`var err;`