Merge pull request brianc#129 from janstice/patch-1

diwu1989 · diwu1989 · commit fd3ecefb5380 · 2013-08-23T16:52:50.000-07:00
Allow qualified column names w/ aggregate functions
diff --git a/lib/dialect/postgres.js b/lib/dialect/postgres.js
@@ -463,10 +463,10 @@ Postgres.prototype.visitColumn = function(columnNode) {
   }
   if(!this._visitedInsert && !this._visitingUpdateTargetColumn && !this._visitingCreate && !this._visitingAlter) {
     if(table.alias) {
-      txt = this.quote(table.alias);
+      txt += this.quote(table.alias);
     } else {
       if(table.getSchema()) {
-        txt = this.quote(table.getSchema());
+        txt += this.quote(table.getSchema());
         txt += '.';
       }
       txt += this.quote(table.getName());

Original file line number	Diff line number	Diff line change
`@@ -463,10 +463,10 @@ Postgres.prototype.visitColumn = function(columnNode) {`
`463`	`463`	`}`
`464`	`464`	`if(!this._visitedInsert && !this._visitingUpdateTargetColumn && !this._visitingCreate && !this._visitingAlter) {`
`465`	`465`	`if(table.alias) {`
`466`		`- txt = this.quote(table.alias);`
	`466`	`+ txt += this.quote(table.alias);`
`467`	`467`	`} else {`
`468`	`468`	`if(table.getSchema()) {`
`469`		`- txt = this.quote(table.getSchema());`
	`469`	`+ txt += this.quote(table.getSchema());`
`470`	`470`	`txt += '.';`
`471`	`471`	`}`
`472`	`472`	`txt += this.quote(table.getName());`