Allow passing plain query as subquery.

braddunbar · braddunbar · commit d0c15622624f · 2015-08-31T13:50:09.000-04:00
diff --git a/lib/dialect/postgres.js b/lib/dialect/postgres.js
@@ -542,6 +542,7 @@ Postgres.prototype.visitOverlap = function(overlap) {
 };
 
 Postgres.prototype.visitQuery = function(queryNode) {
+  if (this._queryNode) return this.visitSubquery(queryNode);
   this._queryNode = queryNode;
   // need to sort the top level query nodes on visitation priority
   // so select/insert/update/delete comes before from comes before where
diff --git a/test/dialects/subquery-tests.js b/test/dialects/subquery-tests.js
@@ -3,8 +3,34 @@
 var Harness = require('./support');
 var customer = Harness.defineCustomerTable();
 var user = Harness.defineUserTable();
+var post = Harness.definePostTable();
 var Sql = require('../../lib');
 
+Harness.test({
+  query: user.select(user.name).where(user.id.in(post.select(post.userId))),
+  pg: {
+    text:   'SELECT "user"."name" FROM "user" WHERE ("user"."id" IN (SELECT "post"."userId" FROM "post"))',
+    string: 'SELECT "user"."name" FROM "user" WHERE ("user"."id" IN (SELECT "post"."userId" FROM "post"))'
+  },
+  sqlite: {
+    text:   'SELECT "user"."name" FROM "user" WHERE ("user"."id" IN (SELECT "post"."userId" FROM "post"))',
+    string: 'SELECT "user"."name" FROM "user" WHERE ("user"."id" IN (SELECT "post"."userId" FROM "post"))'
+  },
+  mysql: {
+    text:   'SELECT `user`.`name` FROM `user` WHERE (`user`.`id` IN (SELECT `post`.`userId` FROM `post`))',
+    string: 'SELECT `user`.`name` FROM `user` WHERE (`user`.`id` IN (SELECT `post`.`userId` FROM `post`))'
+  },
+  mssql: {
+    text:   'SELECT [user].[name] FROM [user] WHERE ([user].[id] IN (SELECT [post].[userId] FROM [post]))',
+    string: 'SELECT [user].[name] FROM [user] WHERE ([user].[id] IN (SELECT [post].[userId] FROM [post]))',
+  },
+  oracle: {
+    text:   'SELECT "user"."name" FROM "user" WHERE ("user"."id" IN (SELECT "post"."userId" FROM "post"))',
+    string: 'SELECT "user"."name" FROM "user" WHERE ("user"."id" IN (SELECT "post"."userId" FROM "post"))'
+  },
+  params: []
+})
+
 Harness.test({
   query: user.name.in(
     customer.subQuery().select(customer.name).where(
