Merge pull request brianc#38 from esessoms/chainable-joins

brianc · brianc · commit 4493f7826b21 · 2013-02-25T12:11:35.000-08:00
should be able to chain leftJoin
diff --git a/lib/node/join.js b/lib/node/join.js
@@ -11,5 +11,8 @@ var JoinNode = module.exports = require(__dirname).define({
   },
   join: function(other) {
     return new JoinNode('INNER', this, other);
+  },
+  leftJoin: function(other) {
+    return new JoinNode('LEFT', this, other);
   }
 });
diff --git a/test/postgres/join-tests.js b/test/postgres/join-tests.js
@@ -25,6 +25,18 @@ Harness.test({
   pg    : 'SELECT "user"."name", "post"."content" FROM "user" LEFT JOIN "post" ON ("user"."id" = "post"."userId")'
 });
 
+Harness.test({
+  query : user
+            .select(user.name, post.content)
+            .from(
+              user
+                .leftJoin(post).on(user.id.equals(post.userId))
+                .leftJoin(comment).on(post.id.equals(comment.postId))
+            ),
+  pg    : 'SELECT "user"."name", "post"."content" FROM "user" LEFT JOIN "post" ON ("user"."id" = "post"."userId")' +
+          ' LEFT JOIN "comment" ON ("post"."id" = "comment"."postId")'
+});
+
 Harness.test({
   query : user
     .select(user.name, post.content)

Original file line number	Diff line number	Diff line change
`@@ -11,5 +11,8 @@ var JoinNode = module.exports = require(__dirname).define({`
`11`	`11`	`},`
`12`	`12`	`join: function(other) {`
`13`	`13`	`return new JoinNode('INNER', this, other);`
	`14`	`+ },`
	`15`	`+ leftJoin: function(other) {`
	`16`	`+ return new JoinNode('LEFT', this, other);`
`14`	`17`	`}`
`15`	`18`	`});`