SONARJAVA-3454 FP in S2970 when "assertThatThrownBy" is used alone

quentin-jaquier-sonarsource · quentin-jaquier-sonarsource · commit 44e03ee2e428 · 2020-07-07T09:46:31.000+02:00
diff --git a/java-checks-test-sources/src/main/java/checks/AssertionsCompletenessCheck.java b/java-checks-test-sources/src/main/java/checks/AssertionsCompletenessCheck.java
@@ -98,9 +98,9 @@ public void assertj_assertions() {
     org.assertj.core.api.Assertions.assertThat(1).usingDefaultComparator(); // Noncompliant
     org.assertj.core.api.Assertions.assertThatObject(null).extracting("name"); // Noncompliant
     org.assertj.core.api.Assertions.assertThatObject(null).extracting("name").isEqualTo("Paul");
-    org.assertj.core.api.Assertions.assertThatThrownBy(() -> {}).describedAs(""); // Noncompliant
+    org.assertj.core.api.Assertions.assertThatThrownBy(() -> {}).describedAs(""); // Compliant, can be used alone (will fail if not exception is used).
     org.assertj.core.api.Assertions.assertThatThrownBy(() -> {}).describedAs("").hasMessage("42");
-    org.assertj.core.api.Assertions.assertThatThrownBy(() -> {}, "desc", 42).usingComparator(null); // Noncompliant
+    org.assertj.core.api.Assertions.assertThatThrownBy(() -> {}, "desc", 42).usingComparator(null); // Compliant
     org.assertj.core.api.Assertions.assertThatThrownBy(() -> {}, "desc", 42).usingComparator(null).isInstanceOf(IllegalStateException.class);
     org.assertj.core.api.Assertions.assertThatCode(() -> {}); // Noncompliant
     org.assertj.core.api.Assertions.assertThatCode(() -> {}).isInstanceOf(IllegalStateException.class);
diff --git a/java-checks/src/main/java/org/sonar/java/checks/tests/AssertionsCompletenessCheck.java b/java-checks/src/main/java/org/sonar/java/checks/tests/AssertionsCompletenessCheck.java
@@ -99,7 +99,6 @@ public class AssertionsCompletenessCheck extends BaseTreeVisitor implements Java
         "org.assertj.core.api.Assertions")
       .names(
         "assertThatObject",
-        "assertThatThrownBy",
         "assertThatCode",
         "assertThatExceptionOfType",
         "assertThatNullPointerException",
