Leader Follower initial commit by amit2103 · Pull Request #423 · iluwatar/java-design-patterns

amit2103 · 2016-04-13T15:52:44Z

Pull request for issue #179 (Leader Follower Pattern). Made some changes as per feedback. In order to reduce merge conflicts making this new request

Added two modules to demonstrate locks. Mutex demonstrates a simple mutual exclusion lock. Semaphore demonstrates a semaphore for controlling access to a pool of resources. The main class of both programs is App.java.

- Added descriptions - Added junit tests - Added javadoc - Added index.md - Added class diagrams

basic implementation ++

Resubmit of updates

…point to retrieve an image path

…point to retrieve a price

…lls to the Image and Price microservices

Test/Doc added

Second type mapper is updated to use java.util.vector

coveralls · 2016-04-13T16:11:17Z

Coverage decreased (-0.03%) to 90.983% when pulling 3ed72c7 on amit2103:leader-follower-2 into b72214d on iluwatar:master.

amit2103 · 2016-04-25T05:19:13Z

@iluwatar Okay..Will update the branch

iluwatar · 2016-05-01T17:15:04Z

@amit2103 the conflicts still persist.

amit2103 · 2016-05-01T19:42:00Z

@iluwatar resolved..will update by Tuesday

…service. Change api-gateway packaging type to "pom". Update price-microservice and image-microservice to be true submodules of api-gateway

… reference them from api-gateway submodule pom.xml files

iluwatar#297 Create API Gateway pattern

amit2103 · 2016-05-08T06:34:52Z

@iluwatar updated...please look at this now .

coveralls · 2016-05-08T06:51:04Z

Coverage decreased (-0.6%) to 90.361% when pulling 47e5972 on amit2103:leader-follower-2 into b72214d on iluwatar:master.

iluwatar · 2016-05-08T17:31:22Z

@amit2103 the Leader-Follower itself looks quite good but the changelist contains huge amount of changes to other patterns. Please revert the unnecessary changes.

amit2103 · 2016-05-09T09:28:15Z

Is it possible to cherry pick? It seems the changes are added from the
rebase, as I Definitely didnt change the files

On Sun, May 8, 2016 at 11:02 PM, Ilkka Seppälä notifications@github.com
wrote:

@amit2103 https://github.com/amit2103 the Leader-Follower itself looks
quite good but the changelist contains huge amount of changes to other
patterns. Please revert the unnecessary changes.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#423 (comment)

iluwatar · 2016-05-12T05:05:29Z

@amit2103 you can reset the files you didn't want to change by checking them out from master branch. For example git checkout master -- api-gateway/README.md would reset one file.

amit2103 · 2016-05-12T05:27:32Z

Okay...Will try this today.

On Thu, May 12, 2016 at 10:36 AM, Ilkka Seppälä notifications@github.com
wrote:

@amit2103 https://github.com/amit2103 you can reset the files you
didn't want to change by checking them out from master branch. For
example git checkout master -- api-gateway/README.md would reset one file.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#423 (comment)

iluwatar · 2016-06-24T12:32:22Z

@amit2103 final call, I'm about to close this pull request due to inactivity.

amit2103 · 2016-06-24T13:35:24Z

Apologies for the delay..I will get this done by tomorrow...

amit2103 · 2016-06-28T08:33:14Z

@iluwatar Do you know why I keep getting this updates when I am rebasing the origin..I was trying to do it again..But saw some changes? Is there a way to avoid it

iluwatar · 2016-06-28T18:44:54Z

Hey @amit2103 what are trying to do? Maybe this helps https://help.github.com/articles/syncing-a-fork/

amit2103 · 2016-06-29T05:15:33Z

I tried to rebase , let me try merge

On Wed, Jun 29, 2016 at 12:15 AM, Ilkka Seppälä notifications@github.com
wrote:

Hey @amit2103 https://github.com/amit2103 what are trying to do? Maybe
this helps https://help.github.com/articles/syncing-a-fork/

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#423 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AHN1ZKSGYerRVj5inNJCXa2EkbExTr03ks5qQWvfgaJpZM4IGies
.

iluwatar · 2016-06-30T15:10:24Z

First merge master, then use the checkout command to reset the unwanted changes as I wrote before.

iluwatar · 2016-08-20T17:53:29Z

I'm closing this pull request due to inactivity.

iluwatar · 2020-07-28T16:43:38Z

@all-contributors please add @amit2103 for code

allcontributors · 2020-07-28T16:43:46Z

@iluwatar

I've put up a pull request to add @amit2103! 🎉

TylerMcConville and others added 20 commits February 7, 2016 17:05

iluwatar#297 Create API Gateway pattern

88c3b04

iluwatar#297 Create unit tests for Gateway API pattern

3cbb88e

Added mutex and semaphore modules to demonstrate locks

3ed3bc1

Added two modules to demonstrate locks. Mutex demonstrates a simple mutual exclusion lock. Semaphore demonstrates a semaphore for controlling access to a pool of resources. The main class of both programs is App.java.

Update according to review comments iluwatar#397

6e4b269

- Added descriptions - Added junit tests - Added javadoc - Added index.md - Added class diagrams

basic implementation ++

28a5a43

basic implementation ++

Merge remote-tracking branch 'refs/remotes/iluwatar/master'

474f265

Update According to Review Comments iluwatar#397

e2af78f

Resubmit of updates

Merge remote-tracking branch 'iluwatar/master'

187658c

iluwatar#297 Create Spring Boot-backed Image microservice with an end…

0c6d3f2

…point to retrieve an image path

iluwatar#297 Create Spring Boot-backed Price microservice with an end…

01737bc

…point to retrieve a price

iluwatar#297 Create Spring Boot-backed API Gateway that aggregates ca…

665256e

…lls to the Image and Price microservices

iluwatar#297 Create unit test for ImageController

e80583f

iluwatar#297 Create unit test for PriceController

4ebb64c

JDBC removed...

deb15e2

JDBC removed...

eb72493

Test/Doc added

59b6b81

Test/Doc added

Second type mapper is updated to use java.util.vector

822ab8d

Second type mapper is updated to use java.util.vector

Intent++

c53dcf1

Applicability++

06e0a15

Leader Follower initial commit

3ed72c7

amit2103 mentioned this pull request Apr 13, 2016

Leader follower #318

Closed

gwildor28 and others added 8 commits April 13, 2016 18:51

Merge remote-tracking branch 'refs/remotes/iluwatar/master'

1fd15d5

pom update

3f9a756

pom update

ca8be7c

added relative paths to pom in mutex/semaphore

685d093

updated version to fix pom

e821abd

Fix minor display error

439e286

Fix display error

8e69ebc

Fix display error

cf0570a

iluwatar#297 Fix error in README

b115c61

TylerMcConville and others added 9 commits May 3, 2016 16:28

iluwatar#297 Update license headers

5abd20f

iluwatar#297 Update category and tags in README

a6036e5

iluwatar#297 Move API Gateway code into a new submodule: api-gateway-…

8653eb8

…service. Change api-gateway packaging type to "pom". Update price-microservice and image-microservice to be true submodules of api-gateway

iluwatar#297 Add new dependencies to java-design-patterns/pom.xml and…

dd23853

… reference them from api-gateway submodule pom.xml files

iluwatar#297 Update class diagram to reflect new location of files

f234a68

Merge pull request iluwatar#427 from surgeforward/297

0ad9937

iluwatar#297 Create API Gateway pattern

Improve Singleton holder example

2ed3748

Leader Follower initial commit

2b5e26f

Fixed merge conflicts

47e5972

iluwatar closed this Aug 20, 2016

allcontributors Bot mentioned this pull request Jul 28, 2020

docs: add amit2103 as a contributor #1384

Merged

Uh oh!

Conversation

amit2103 commented Apr 13, 2016

Uh oh!

coveralls commented Apr 13, 2016

Uh oh!

amit2103 commented Apr 25, 2016

Uh oh!

iluwatar commented May 1, 2016

Uh oh!

amit2103 commented May 1, 2016

Uh oh!

amit2103 commented May 8, 2016

Uh oh!

coveralls commented May 8, 2016

Uh oh!

iluwatar commented May 8, 2016

Uh oh!

amit2103 commented May 9, 2016

Uh oh!

iluwatar commented May 12, 2016

Uh oh!

amit2103 commented May 12, 2016

Uh oh!

iluwatar commented Jun 24, 2016

Uh oh!

amit2103 commented Jun 24, 2016

Uh oh!

amit2103 commented Jun 28, 2016

Uh oh!

iluwatar commented Jun 28, 2016

Uh oh!

amit2103 commented Jun 29, 2016

Uh oh!

iluwatar commented Jun 30, 2016

Uh oh!

iluwatar commented Aug 20, 2016

Uh oh!

iluwatar commented Jul 28, 2020

Uh oh!

allcontributors Bot commented Jul 28, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants