Value object pattern #349#362
Merged
Merged
Conversation
Added index.md with explanation which seems a little bit short of detail. Fixed the directory of the files.
Owner
|
Could you catch up the branch from the master, it has conflicts. |
Owner
There was a problem hiding this comment.
Did you mean to change this file?
Contributor
Author
|
I'll catch up changes, add description as you asked. Sorry for not checking trivial mistakes making other files to change. I'll comment on this thread when done. |
Contributor
Author
There was a problem hiding this comment.
I don't know why these blanks exist and make differences in this file. I only added one line value-object.
Contributor
Author
|
I think the fixes are done. please review. #362 |
Owner
|
Thanks @JuhoKang this looks good! |
Owner
|
@all-contributors please add @JuhoKang for code |
Contributor
|
I've put up a pull request to add @JuhoKang! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation for the Value Object pattern.
I had some difficulties to show all of the VALJO things so just stopped in the middle and just implemented some "must do" things in the code.