Skip to content

updated Random() to SecureRandom()#1670

Merged
iluwatar merged 2 commits into
iluwatar:masterfrom
ohbus:security-hotspots
Mar 6, 2021
Merged

updated Random() to SecureRandom()#1670
iluwatar merged 2 commits into
iluwatar:masterfrom
ohbus:security-hotspots

Conversation

@ohbus
Copy link
Copy Markdown
Contributor

@ohbus ohbus commented Mar 6, 2021

As reported by SonarCloud use should use SecureRandom() instead of Random()

@ohbus ohbus requested a review from iluwatar March 6, 2021 09:16
@ohbus ohbus force-pushed the security-hotspots branch from 62fdc52 to 51b4ec3 Compare March 6, 2021 09:18
@ohbus
Copy link
Copy Markdown
Contributor Author

ohbus commented Mar 6, 2021

If there are any static code errors, I will fix in the meantime!

Thanks.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 6, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

86.7% 86.7% Coverage
0.0% 0.0% Duplication

@iluwatar iluwatar added this to the 1.24.0 milestone Mar 6, 2021
@iluwatar iluwatar merged commit b423002 into iluwatar:master Mar 6, 2021
@iluwatar
Copy link
Copy Markdown
Owner

iluwatar commented Mar 6, 2021

Good improvement, thanks @ohbus 👍🏻

@ohbus ohbus deleted the security-hotspots branch March 7, 2021 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants