#1638 Add Parameter Object pattern#1650
Conversation
ohbus
left a comment
There was a problem hiding this comment.
Thanks @richardmr36 for your awesome contribution ⭐
Overall a Very Good PR 🥳
There are a few things I would like you to consider before we can merge this:
- Few more test cases to increase the coverage of the code.
- Look into the comments to add a few extra lines.
- Commenting the Code to understand why certain actions are being taken
- Logging the output.
Once these changes are updated, you can request another review.
Looking forward to it.
|
@ohbus Regarding logging the output, there is only one output (in App.java) and it's being logged. Let me know if you are talking about anything specific to log. |
It is like when the tests are running, if there are certains logs of how it is performing with the values, it would suffice. |
ohbus
left a comment
There was a problem hiding this comment.
Thanks for the update.
There are a few minor changes I would like you to go through.
iluwatar
left a comment
There was a problem hiding this comment.
Looks extremely good already, but added just a couple of minor comments
|
Many thanks @richardmr36 for the valuable contribution! |
|
I've put up a pull request to add @richardmr36! 🎉 |
|
Web site link: https://java-design-patterns.com/patterns/parameter-object/ |
This PR introduces Parameter Object pattern. It has a working example with tests and explanations.