Issue 893#1014
Merged
Merged
Conversation
iluwatar
reviewed
Oct 17, 2019
Owner
iluwatar
left a comment
There was a problem hiding this comment.
Build is failing due to checkstyle errors
Owner
|
@hbothra15 some changes were requested |
Contributor
Author
|
Yes @iluwatar, |
Owner
|
Let me know when it's ready for another review |
Contributor
Author
|
It's ready for your review |
iluwatar
requested changes
Oct 26, 2019
Comment on lines
+98
to
+99
| System.out.println(clazz); | ||
| System.out.println(weapon); |
Owner
There was a problem hiding this comment.
Either remove these console printouts or use proper logger
Contributor
Author
|
Changes has been made and updated the README.md file to be aligned with new code |
iluwatar
approved these changes
Oct 30, 2019
Owner
|
Thanks a lot @hbothra15 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Static factory method
Pull request description