Make getInterpreters() API faster for subsequent calls (microsoft#16674)

Kartik Raj · web-flow · commit f63dac937945 · 2021-07-13T14:04:36.000-07:00
diff --git a/src/client/common/experiments/helpers.ts b/src/client/common/experiments/helpers.ts
@@ -13,3 +13,10 @@ export async function inDiscoveryExperiment(experimentService: IExperimentServic
     ]);
     return results.includes(true);
 }
+
+export function inDiscoveryExperimentSync(experimentService: IExperimentService): boolean {
+    return (
+        experimentService.inExperimentSync(DiscoveryVariants.discoverWithFileWatching) ||
+        experimentService.inExperimentSync(DiscoveryVariants.discoveryWithoutFileWatching)
+    );
+}
diff --git a/src/client/interpreter/interpreterService.ts b/src/client/interpreter/interpreterService.ts
@@ -33,7 +33,7 @@ import {
 } from './contracts';
 import { IVirtualEnvironmentManager } from './virtualEnvs/types';
 import { getInterpreterHash } from '../pythonEnvironments/discovery/locators/services/hashProvider';
-import { inDiscoveryExperiment } from '../common/experiments/helpers';
+import { inDiscoveryExperiment, inDiscoveryExperimentSync } from '../common/experiments/helpers';
 import { StopWatch } from '../common/utils/stopWatch';
 import { PythonVersion } from '../pythonEnvironments/info/pythonVersion';
 
@@ -139,7 +139,7 @@ export class InterpreterService implements Disposable, IInterpreterService {
     public async getInterpreters(resource?: Uri, options?: GetInterpreterOptions): Promise<PythonEnvironment[]> {
         let environments: PythonEnvironment[] = [];
         const stopWatch = new StopWatch();
-        if (await inDiscoveryExperiment(this.experimentService)) {
+        if (inDiscoveryExperimentSync(this.experimentService)) {
             environments = await this.pyenvs.getInterpreters(resource, options);
         } else {
             const locator = this.serviceContainer.get<IInterpreterLocatorService>(
